The approach so far is optional (behind a profile), iin any case contributions are more than welcome to fix the error-prone detected issues once this is merged.
On Tue, Feb 13, 2018 at 10:03 PM, Eugene Kirpichov <kirpic...@google.com> wrote: > Oh! I had no idea this was already in progress - thanks Kenn! > > > On Tue, Feb 13, 2018, 12:23 PM Ismaël Mejía <ieme...@gmail.com> wrote: >> >> Kenn submitted a PR for this yesterday. So I assume is taken. >> https://github.com/apache/beam/pull/4667 >> >> On Tue, Feb 13, 2018 at 8:49 PM, Eugene Kirpichov <kirpic...@google.com> >> wrote: >> > Filed https://issues.apache.org/jira/browse/BEAM-3697 >> > >> > This seems to be a good task for a new contributor, easy and potentially >> > with high payoff (uncovering bugs), and a good way to become cursorily >> > familiar with diverse parts of the codebase by fixing the bugs it finds. >> > >> > Any takers? >> > >> > Description: >> > >> > http://errorprone.info/ is a good static checker that covers a number of >> > bugs not covered by FindBugs or Checkstyle. We use it internally at >> > Google >> > and, when run on the Beam codebase, it occasionally uncovers issues >> > missed >> > during PR review process. >> > >> > It has Maven and Gradle plugins: >> > http://errorprone.info/docs/installation >> > https://github.com/tbroyer/gradle-errorprone-plugin >> > >> > It would be good to integrate it into our Maven and Gradle builds.