on maven it is quite reliable, ran it > 10 times without any failure.

I suspect (but didnt check by lack of time) gradle parallelism is
different somehow and can lead to some flackyness here.

Romain Manni-Bucau
@rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book


2018-04-12 18:20 GMT+02:00 Scott Wegner <sweg...@google.com>:
> It looks like the precommit failure [1] is for a new test that was added.
> Have you debugged the test to ensure it's not flaky?
>
> [1]
> https://builds.apache.org/job/beam_PreCommit_Java_GradleBuild/4059/testReport/junit/org.apache.beam.runners.direct/ExecutorServiceParallelExecutorTest/ensureMetricsThreadDoesntLeak/
>
> On Thu, Apr 12, 2018 at 5:06 AM Romain Manni-Bucau <rmannibu...@gmail.com>
> wrote:
>>
>> Hi guys,
>>
>> did the gradle track changed the way test execution was done?
>>
>> This PR https://github.com/apache/beam/pull/4965 works very well with
>> maven and sometimes doesn't pass with gradle. Think we should keep the
>> previous setup which was globally reliable (I'm not speaking of tests
>> which are not but of the setup).
>>
>> Any inputs or in progress todo i missed?
>>
>> Romain Manni-Bucau
>> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>
> --
>
>
> Got feedback? http://go/swegner-feedback

Reply via email to