Sorry, no -1, at least not at this time. This is only a suspected issue. Even the referenced issue is not a formal ruling, with some dissenting opinions, and a programatic suggestion that most are comfortable with. (Personally, I probably lean on the side that inclusion of this file is fine.)
But, it is something that warrants a discussion... On Wed, Jun 20, 2018 at 9:47 AM, Lukasz Cwik <lc...@google.com> wrote: > Davor, please -1 the release if you believe LEGAL-288 applies. > > On Wed, Jun 20, 2018 at 9:37 AM Davor Bonaci <da...@apache.org> wrote: > >> Please take a peek at LEGAL-288 [1], which I learned about recently in >> the context of another project. Looks like an issue, requiring a new RC, >> but I didn't have a chance to look closely. >> >> Thanks. >> >> Davor >> >> [1] https://issues.apache.org/jira/browse/LEGAL-288 >> >> On Wed, Jun 20, 2018 at 9:17 AM, Pablo Estrada <pabl...@google.com> >> wrote: >> >>> +1 (binding) >>> >>> On Wed, Jun 20, 2018 at 9:08 AM Lukasz Cwik <lc...@google.com> wrote: >>> >>>> +1 (binding) >>>> >>>> On Tue, Jun 19, 2018 at 10:39 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> >>>>> +1 (binding) >>>>> >>>>> Regards >>>>> JB >>>>> >>>>> On 17/06/2018 07:18, Jean-Baptiste Onofré wrote: >>>>> > Hi everyone, >>>>> > >>>>> > Please review and vote on the release candidate #2 for the version >>>>> > 2.5.0, as follows: >>>>> > >>>>> > [ ] +1, Approve the release >>>>> > [ ] -1, Do not approve the release (please provide specific comments) >>>>> > >>>>> > NB: this is the first release using Gradle, so don't be too harsh ;) >>>>> A >>>>> > PR about the release guide will follow thanks to this release. >>>>> > >>>>> > The complete staging area is available for your review, which >>>>> includes: >>>>> > * JIRA release notes [1], >>>>> > * the official Apache source release to be deployed to >>>>> dist.apache.org >>>>> > [2], which is signed with the key with fingerprint C8282E76 [3], >>>>> > * all artifacts to be deployed to the Maven Central Repository [4], >>>>> > * source code tag "v2.5.0-RC2" [5], >>>>> > * website pull request listing the release and publishing the API >>>>> > reference manual [6]. >>>>> > * Java artifacts were built with Gradle 4.7 (wrapper) and >>>>> OpenJDK/Oracle >>>>> > JDK 1.8.0_172 (Oracle Corporation 25.172-b11). >>>>> > * Python artifacts are deployed along with the source release to the >>>>> > dist.apache.org [2]. >>>>> > >>>>> > The vote will be open for at least 72 hours. It is adopted by >>>>> majority >>>>> > approval, with at least 3 PMC affirmative votes. >>>>> > >>>>> > Thanks, >>>>> > JB >>>>> > >>>>> > [1] >>>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >>>>> ctId=12319527&version=12342847 >>>>> > [2] https://dist.apache.org/repos/dist/dev/beam/2.5.0/ >>>>> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>> > [4] https://repository.apache.org/content/repositories/orgapache >>>>> beam-1043/ >>>>> > [5] https://github.com/apache/beam/tree/v2.5.0-RC2 >>>>> > [6] https://github.com/apache/beam-site/pull/463 >>>>> > >>>>> >>>>> -- >>>>> Jean-Baptiste Onofré >>>>> jbono...@apache.org >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>>>> >>>> -- >>> Got feedback? go/pabloem-feedback >>> <https://goto.google.com/pabloem-feedback> >>> >> >>
