+1 Thanks for removing the jar, Robert. On Fri, Jun 22, 2018 at 11:48 AM Robert Bradshaw <[email protected]> wrote:
> I was waiting for the gradlew jar file to be removed from the source > release, but I figured it made more sense to just jump in and help > out. > > $ git show-ref github/release-2.5.0 > 093ac64bc2d59f3d58c0f0e7f65f2a36eaf26a4a refs/remotes/github/release-2.5.0 > > $ wget https://github.com/apache/beam/archive/release-2.5.0.zip -O > apache-beam-2.5.0-source-release.zip > $ zip -d apache-beam-2.5.0-source-release.zip > beam-release-2.5.0/gradle/wrapper/gradle-wrapper.jar > [signed and uploaded] > > I also uploaded the wheels to dist (which I worked on with Boyuan, and > were verified by Yifan), putting all the python artifacts in a python > sub-directory. > > I can now say +1 (binding) to this release. > On Fri, Jun 22, 2018 at 9:47 AM Ahmet Altay <[email protected]> wrote: > > > > I already voted a +1 2 days ago. > > > > Again: > > > > +1 (binding) > > > > Thank you JB! > > > > On Fri, Jun 22, 2018 at 9:23 AM, Alan Myrvold <[email protected]> > wrote: > >> > >> The > https://dist.apache.org/repos/dist/dev/beam/2.5.0/apache-beam-2.5.0-source-release.zip > still contains the beam-release-2.5.0/gradle/wrapper/gradle-wrapper.jar. > Does that need to be removed before releasing it? > >> > >> On Fri, Jun 22, 2018 at 9:11 AM Reuven Lax <[email protected]> wrote: > >>> > >>> +1 (binding) > >>> > >>> On Fri, Jun 22, 2018 at 7:51 AM Jean-Baptiste Onofré <[email protected]> > wrote: > >>>> > >>>> Gently reminder for the PMC member. > >>>> > >>>> Right now, if I'm not wrong, we only have two concrete binding votes > >>>> (Luke and I). > >>>> > >>>> As reminder, to pass, the vote needs at least 3 binding votes (a > binding > >>>> vote is a vote from a PMC member). > >>>> > >>>> So, we would need an additional formal binding vote. > >>>> > >>>> NB: I prepared the apache-beam-wheels on my github and trigger a build > >>>> on Travis. However, I have a build issue that I have to investigate. > >>>> > >>>> Thanks, > >>>> Regards > >>>> JB > >>>> > >>>> On 17/06/2018 07:18, Jean-Baptiste Onofré wrote: > >>>> > Hi everyone, > >>>> > > >>>> > Please review and vote on the release candidate #2 for the version > >>>> > 2.5.0, as follows: > >>>> > > >>>> > [ ] +1, Approve the release > >>>> > [ ] -1, Do not approve the release (please provide specific > comments) > >>>> > > >>>> > NB: this is the first release using Gradle, so don't be too harsh > ;) A > >>>> > PR about the release guide will follow thanks to this release. > >>>> > > >>>> > The complete staging area is available for your review, which > includes: > >>>> > * JIRA release notes [1], > >>>> > * the official Apache source release to be deployed to > dist.apache.org > >>>> > [2], which is signed with the key with fingerprint C8282E76 [3], > >>>> > * all artifacts to be deployed to the Maven Central Repository [4], > >>>> > * source code tag "v2.5.0-RC2" [5], > >>>> > * website pull request listing the release and publishing the API > >>>> > reference manual [6]. > >>>> > * Java artifacts were built with Gradle 4.7 (wrapper) and > OpenJDK/Oracle > >>>> > JDK 1.8.0_172 (Oracle Corporation 25.172-b11). > >>>> > * Python artifacts are deployed along with the source release to the > >>>> > dist.apache.org [2]. > >>>> > > >>>> > The vote will be open for at least 72 hours. It is adopted by > majority > >>>> > approval, with at least 3 PMC affirmative votes. > >>>> > > >>>> > Thanks, > >>>> > JB > >>>> > > >>>> > [1] > >>>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12342847 > >>>> > [2] https://dist.apache.org/repos/dist/dev/beam/2.5.0/ > >>>> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS > >>>> > [4] > https://repository.apache.org/content/repositories/orgapachebeam-1043/ > >>>> > [5] https://github.com/apache/beam/tree/v2.5.0-RC2 > >>>> > [6] https://github.com/apache/beam-site/pull/463 > >>>> > > >>>> > >>>> -- > >>>> Jean-Baptiste Onofré > >>>> [email protected] > >>>> http://blog.nanthrax.net > >>>> Talend - http://www.talend.com > > > > >
