Python already has lint checks: :beam-sdks-python:lint There are autoformatting tools, which we don't use AFAIK: https://github.com/myint/autoflake https://github.com/hhatto/autopep8
On Thu, Jun 28, 2018 at 12:31 AM Daniel Kulp <dk...@apache.org> wrote: > > > On Jun 28, 2018, at 6:01 AM, Kenneth Knowles <k...@google.com> wrote: > > So, there are a few modes of checkstyle failure that can be induced by > this: > > - lines get too long because of wrap & indent logic > - a lot of our HTML is actually already broken and doesn't have <p> tags > where it should; spotless adds a blank line which makes checkstyle notice > the errors > > I think that autoformat outweighs these. I propose that we comment out > these checkstyle rules, turn on autoformat, then gradually restore the > rules. I have adjusted my pull request accordingly. > > > Yea… when I was adding all the whitespace rules to checkstyle config, I > looked at the spotless stuff and could not find a set of rules for > checkstyle that would 100% meet the spotless output. I fully expect to > need to disable a few of the rules. However, if spotless is run > automatically so the code is always formatted correctly, checkstyle is > redundant. > > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > >
smime.p7s
Description: S/MIME Cryptographic Signature
