+1! On Tue, Jul 10, 2018 at 8:51 AM Robert Burke <rob...@frantil.com> wrote:
> +1 > If non-committers are welcome in the file, I'm happy to assist Henning > with Go SDK reviews.(@lostluck) > > > On Tue, Jul 10, 2018, 8:47 AM Alexey Romanenko <aromanenko....@gmail.com> > wrote: > >> +1, >> Udi, thank you for taking care of this! >> I added myself as a reviewer of some IO components. >> >> >> On 10 Jul 2018, at 17:00, Henning Rohde <hero...@google.com> wrote: >> >> +1. Sounds like a useful improvement. >> >> Udi -- do the reviewers in this file need to be committers for the PR >> auto-assignment to work? >> >> On Tue, Jul 10, 2018 at 1:59 AM Łukasz Gajowy <lukasz.gaj...@gmail.com> >> wrote: >> >>> +1. It will certainly be useful. I added myself (and a fellow >>> contributor) to some components (IO testing related mostly). >>> >>> Thanks, >>> Łukasz >>> >>> wt., 10 lip 2018 o 02:06 Udi Meiri <eh...@google.com> napisał(a): >>> >>>> Hi everyone, >>>> >>>> I'm proposing to add auto-reviewer-assignment using Github's CODEOWNERS >>>> mechanism. >>>> Initial version is here: *https://github.com/apache/beam/pull/5909/files >>>> <https://github.com/apache/beam/pull/5909/files>* >>>> >>>> I need help from the community in determining owners for each component. >>>> Feel free to directly edit the PR (if you have permission) or add a >>>> comment. >>>> >>>> >>>> Background >>>> The idea is to: >>>> 1. Document good review candidates for each component. >>>> 2. Help choose reviewers using the auto-assignment mechanism. The >>>> suggestion is in no way binding. >>>> >>>> >>>> >>
smime.p7s
Description: S/MIME Cryptographic Signature
