Do we happen to know the root cause for why this wasn't caught during review / precommit?
In the future, can we run manually run postcommits for risky changes like these? That is, trigger it by commenting "Run Python PostCommit"? On Fri, Sep 21, 2018 at 10:10 AM Pablo Estrada <[email protected]> wrote: > Robbe has prepared a better fix on > https://github.com/apache/beam/pull/6465 > Hopefully that'll be the last of this breakage : ) > -P. > > On Fri, Sep 21, 2018 at 9:13 AM Jean-Baptiste Onofré <[email protected]> > wrote: > >> By the way, it fails for me on my machine as well. >> >> Regards >> JB >> >> On 21/09/2018 18:10, Pablo Estrada wrote: >> > I investigated. This failure comes from the activation of >> > apache_beam.pipeline_test in Python 3 unit tests. >> > >> > I have https://github.com/apache/beam/pull/6464 out to fix this. >> > >> > In any case, it's very exciting that we have some unit tests running on >> > Py3 : ) >> > Best >> > -P. >> > >> > On Fri, Sep 21, 2018 at 6:40 AM Maximilian Michels <[email protected] >> > <mailto:[email protected]>> wrote: >> > >> > Hi, >> > >> > The Python PreCommit tests are currently broken. Is anybody looking >> > into >> > this? >> > >> > Example: >> > >> https://builds.apache.org/job/beam_PreCommit_Python_Commit/1308/#showFailuresLink >> > JIRA: https://issues.apache.org/jira/browse/BEAM-5458 >> > >> > I'm sure this was just an accident. No big deal but let's make sure >> > PreCommit passes when merging. A broken PreCommit means that we >> can't >> > merge any other changes with confidence. >> > >> > Thanks, >> > Max >> > >> >> -- >> Jean-Baptiste Onofré >> [email protected] >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >
