Reuven also hit this and opened https://github.com/apache/beam/pull/7523. I just cloned master and spotlessCheck passed but spotlessApply was not a noop. It seems a bug has been introduced. We do have paddedCell turned on to let spotless deal with non-idempotence (i.e. bugs) in the google-java-format algorithm by looking for cycles, divergence, or convergence. That could be a source of issues.
Kenn On Tue, Jan 15, 2019 at 5:35 PM Kenneth Knowles <[email protected]> wrote: > For context, previously the version of google-java-format used by spotless > was dynamic and arbitrary. Recently it was pinned in > https://github.com/apache/beam/pull/7505/files so we wouldn't get > unpleasant surprises. Of course, now we have an unpleasant surprise. Very > suspicious that the check passed on that PR. Keep an eye open for > continuing issues. > > Kenn > > On Tue, Jan 15, 2019 at 5:23 PM Alex Amato <[email protected]> wrote: > >> I noticed a lot of files got added to one of my PRs when I ran >> spotlessApply. Perhaps the rules for spotless were changed but not applied >> to the branch? >> >> I create a PR for this, if anyone would like to merge it. >> https://github.com/apache/beam/pull/7527/files >> >> Or feel free to make your own PR and merge it. >> >
