Hmm, and it seems that presubmit failed in my PR as well? In my https://github.com/apache/beam/pull/7527/files
Due to some virtual env setup issue. Was there another change at the same time? Or is it caused by spotless https://scans.gradle.com/s/sehczxwqru3ny/console-log?task=:beam-sdks-python:setupVirtualenv :beam-sdks-python:setupVirtualenv FAILED New python executable in /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_ValidatesRunner_Flink_Commit/src/build/gradleenv/1327086738/bin/python2 Also creating executable in /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_ValidatesRunner_Flink_Commit/src/build/gradleenv/1327086738/bin/python Installing setuptools, pkg_resources, pip, wheel... done. Running virtualenv with interpreter /usr/bin/python2 Collecting tox==3.0.0 Using cached https://files.pythonhosted.org/packages/e6/41/4dcfd713282bf3213b0384320fa8841e4db032ddcb80bc08a540159d42a8/tox-3.0.0-py2.py3-none-any.whl Collecting grpcio-tools==1.3.5 Using cached https://files.pythonhosted.org/packages/05/f6/0296e29b1bac6f85d2a8556d48adf825307f73109a3c2c17fb734292db0a/grpcio_tools-1.3.5-cp27-cp27mu-manylinux1_x86_64.whl Collecting pluggy<1.0,>=0.3.0 (from tox==3.0.0) Using cached https://files.pythonhosted.org/packages/2d/60/f58d9e8197f911f9405bf7e02227b43a2acc2c2f1a8cbb1be5ecf6bfd0b8/pluggy-0.8.1-py2.py3-none-any.whl Requirement already satisfied, skipping upgrade: six in /usr/local/lib/python2.7/dist-packages (from tox==3.0.0) (1.11.0) Requirement already satisfied, skipping upgrade: virtualenv>=1.11.2 in /usr/lib/python2.7/dist-packages (from tox==3.0.0) (15.0.1) Collecting py>=1.4.17 (from tox==3.0.0) Using cached https://files.pythonhosted.org/packages/3e/c7/3da685ef117d42ac8d71af525208759742dd235f8094221fdaafcd3dba8f/py-1.7.0-py2.py3-none-any.whl Collecting grpcio>=1.3.5 (from grpcio-tools==1.3.5) Using cached https://files.pythonhosted.org/packages/ab/13/b4f3d8551e0663ad1a6ba8539057ecd0715bcdf3f2eea235f67b248f37cb/grpcio-1.18.0-cp27-cp27mu-manylinux1_x86_64.whl Collecting protobuf>=3.2.0 (from grpcio-tools==1.3.5) Using cached https://files.pythonhosted.org/packages/b8/c2/b7f587c0aaf8bf2201405e8162323037fe8d17aa21d3c7dda811b8d01469/protobuf-3.6.1-cp27-cp27mu-manylinux1_x86_64.whl Requirement already satisfied, skipping upgrade: enum34>=1.0.4 in /usr/local/lib/python2.7/dist-packages (from grpcio>=1.3.5->grpcio-tools==1.3.5) (1.1.6) Collecting futures>=2.2.0 (from grpcio>=1.3.5->grpcio-tools==1.3.5) Using cached https://files.pythonhosted.org/packages/2d/99/b2c4e9d5a30f6471e410a146232b4118e697fa3ffc06d6a65efde84debd0/futures-3.2.0-py2-none-any.whl Requirement already satisfied, skipping upgrade: setuptools in /usr/lib/python2.7/dist-packages (from protobuf>=3.2.0->grpcio-tools==1.3.5) (33.1.1) Installing collected packages: pluggy, py, tox, futures, grpcio, protobuf, grpcio-tools Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/pluggy' Consider using the `--user` option or check the permissions. On Tue, Jan 15, 2019 at 5:40 PM Kenneth Knowles <[email protected]> wrote: > Reuven also hit this and opened https://github.com/apache/beam/pull/7523. > I just cloned master and spotlessCheck passed but spotlessApply was not a > noop. It seems a bug has been introduced. We do have paddedCell turned on > to let spotless deal with non-idempotence (i.e. bugs) in the > google-java-format algorithm by looking for cycles, divergence, or > convergence. That could be a source of issues. > > Kenn > > On Tue, Jan 15, 2019 at 5:35 PM Kenneth Knowles <[email protected]> wrote: > >> For context, previously the version of google-java-format used by >> spotless was dynamic and arbitrary. Recently it was pinned in >> https://github.com/apache/beam/pull/7505/files so we wouldn't get >> unpleasant surprises. Of course, now we have an unpleasant surprise. Very >> suspicious that the check passed on that PR. Keep an eye open for >> continuing issues. >> >> Kenn >> >> On Tue, Jan 15, 2019 at 5:23 PM Alex Amato <[email protected]> wrote: >> >>> I noticed a lot of files got added to one of my PRs when I ran >>> spotlessApply. Perhaps the rules for spotless were changed but not applied >>> to the branch? >>> >>> I create a PR for this, if anyone would like to merge it. >>> https://github.com/apache/beam/pull/7527/files >>> >>> Or feel free to make your own PR and merge it. >>> >>
