The fact that this happened is a real pity. However it is clearly an exception and not the rule. Really few PRs have been long time without review. Can we somehow automatically send a notification if a PR has no assigned reviewers, or if it has not been reviewed after some time as Tim suggested?
On Fri, Jan 25, 2019 at 9:43 AM Tim Robertson <timrobertson...@gmail.com> wrote: > > Thanks Kenn > > I tend to think that timing is the main contributing factor as you note on > the Jira - it slipped down with no reminders / bumps sent on any channels > that I can see. > > Would something that alerts the dev@ list of PRs that have not received any > attention after N days be helpful perhaps? > Even if that only prompts action by one of us to comment on the PR that it's > been acknowledged would likely be enough to engage the contributor - they > would hopefully then ping the individual if it then slips for a long time. > > Next week will be my first I'll be able to work on Beam in 2019, but I'll > comment on that PR now too as it's missing tests. > > > > > > On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles <k...@apache.org> wrote: >> >> The subject line is a quote from BEAM-6324* >> >> This makes me sad. I hope/expect it is a failure to route a pull request to >> the right reviewer. I am less sad about the functionality than the sentiment >> and how a contributor is being discouraged. >> >> Does anyone have ideas that could help? >> >> Kenn >> >> *https://issues.apache.org/jira/browse/BEAM-6324
