@Ahmet sorry I did not have time to check 2.11 release but a fellow Beam
contributor drew my attention on something:
the 2.11 release tag points on commit of 02/26 and this[1] PR was merged 02/20
and that [2] PR was merged on 02/18. So,
both commits should be in the released code but they are not.
[1] https://github.com/apache/beam/pull/7348[2]
https://github.com/apache/beam/pull/7751
So at least for those 2 features the release notes do not comply to content of
the release. Is there a real problem or
did I miss something ?
Etienne
Le lundi 04 mars 2019 à 11:42 -0800, Ahmet Altay a écrit :
> Thank you for the additional votes and validations.
> Update: Binaries are pushed. Website updates are blocked on an issue that is
> preventing beam-site changes to be synced
> the beam website. (INFRA-17953). I am waiting for that to be resolved before
> sending an announcement.
> On Mon, Mar 4, 2019 at 3:00 AM Robert Bradshaw <rober...@google.com> wrote:
> > I see the vote has passed, but +1 (binding) from me as well.
> >
> >
> >
> > On Mon, Mar 4, 2019 at 11:51 AM Jean-Baptiste Onofré <j...@nanthrax.net>
> > wrote:
> >
> > >
> >
> > > +1 (binding)
> >
> > >
> >
> > > Tested with beam-samples.
> >
> > >
> >
> > > Regards
> >
> > > JB
> >
> > >
> >
> > > On 26/02/2019 10:40, Ahmet Altay wrote:
> >
> > > > Hi everyone,
> >
> > > >
> >
> > > > Please review and vote on the release candidate #2 for the version
> >
> > > > 2.11.0, as follows:
> >
> > > >
> >
> > > > [ ] +1, Approve the release
> >
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > > >
> >
> > > > The complete staging area is available for your review, which includes:
> >
> > > > * JIRA release notes [1],
> >
> > > > * the official Apache source release to be deployed to dist.apache.org
> >
> > > > <http://dist.apache.org> [2], which is signed with the key with
> >
> > > > fingerprint 64B84A5AD91F9C20F5E9D9A7D62E71416096FA00 [3],
> >
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> >
> > > > * source code tag "v2.11.0-RC2" [5],
> >
> > > > * website pull request listing the release [6] and publishing the API
> >
> > > > reference manual [7].
> >
> > > > * Python artifacts are deployed along with the source release to the
> >
> > > > dist.apache.org <http://dist.apache.org> [2].
> >
> > > > * Validation sheet with a tab for 2.11.0 release to help with validation
> >
> > > > [8].
> >
> > > >
> >
> > > > The vote will be open for at least 72 hours. It is adopted by majority
> >
> > > > approval, with at least 3 PMC affirmative votes.
> >
> > > >
> >
> > > > Thanks,
> >
> > > > Ahmet
> >
> > > >
> >
> > > > [1]
> >
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12344775
> >
> > > > [2] https://dist.apache.org/repos/dist/dev/beam/2.11.0/
> >
> > > > [3] https://dist.apache.org/repos/dist/release/beam/KEYS
> >
> > > > [4]
> > > > https://repository.apache.org/content/repositories/orgapachebeam-1064/
> >
> > > > [5] https://github.com/apache/beam/tree/v2.11.0-RC2
> >
> > > > [6] https://github.com/apache/beam/pull/7924
> >
> > > > [7] https://github.com/apache/beam-site/pull/587
> >
> > > > [8]
> >
> > > > https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=542393513
> >
> > > >
> >
> > >
> >
> > > --
> >
> > > Jean-Baptiste Onofré
> >
> > > jbono...@apache.org
> >
> > > http://blog.nanthrax.net
> >
> > > Talend - http://www.talend.com
> >
