There's a lot of value to switching to pytest even without xdist. Could we prune back the goals of this first PR to just achieving feature parity with nose, and make a followup PR for xdist?
-chad On Mon, Oct 7, 2019 at 12:04 PM Udi Meiri <eh...@google.com> wrote: > > > On Fri, Oct 4, 2019 at 10:35 AM Chad Dombrova <chad...@gmail.com> wrote: > >> >> I have a WiP PR to convert Beam to use pytest, but it's been stalled. >>> >> >> What would it take to get it back on track? >> > > Besides needing to convert ITs (removing save_main_session), which can be > split out to a later PR, there's verifying that the same set of tests are > collected for each suite. > > >> >> >>> Another nice thing about pytest is that you'll be able to tell which >>> suite a test belongs to. >>> >> >> pytest has a lot of quality of life improvements over nose. The biggest >> and simplest one is that the test name that it prints is in the same format >> as the runner expects for specifying individual tests to run, so you can >> just copy and paste on the command line to run that one test. Genius. >> Also, since it uses directory names for tests and not module names, you can >> tab complete. The whole fixture >> > LOL at the copy-paste issue. > > >> concept is also great, since it gives you a new axis for test >> composability and reuse, instead of just complex sub-classing or >> copy-and-paste. After switching to pytest we went through our tests and >> replaced all of our horrible test mixins with fixtures and the end result >> is much more legible and maintainable. There's honestly nothing I miss >> about nose. >> >> -chad >> >> >> >> >>
