Sounds great.

One thing we probably should address is identifying environments that are
incompatible with runners and trying to fail pipelines early when such
incompatibilities are detected. I think currently we assign environments to
transforms in following well defined locations.

(1) for cross-language transforms expansion service returns the correct
environment that should be used
(2) for everything else, runner sets a proper default environment

If users can set arbitrary environments for transforms we should probably
have mechanisms in place so that runners can detect incompatibilities early
and error out with clear error messages.

Thanks,
Cham

On Wed, Oct 16, 2019 at 6:15 PM Chad Dombrova <chad...@gmail.com> wrote:

> Hi Robert,
>
>> Sounds nice. Is there a design doc (or, perhaps, you could just give an
>> example of what this would look like in this thread)?
>>
>
> I'll follow up shortly with something.  The good news is that this first
> PR is quite straightforward and (I think) is independent of the semantics
> of how an Environment will ultimately be used.  This PR just answers the
> questions: "how do we represent an Environment outside of the portability
> framework, and how do we convert that to and from the portability
> representation?".  We already have very well established patterns for these
> questions.
>
> -chad
>
>
>
>

Reply via email to