+1 for moving/renaming. I agree with Kyle and Michał - there indeed seems to be some confusion. The name "runners/reference" suggests that it's a not production-ready "Runner" (it seems to be neither of those). If possible, maybe sdks/java/portablility is a good place for this?
Łukasz wt., 22 paź 2019 o 16:41 Kyle Weaver <kcwea...@google.com> napisał(a): > I agree this should be moved. PortableRunner.java is analogous to > portable_runner.py, which resides under > sdks/python/apache_beam/runners/portability. Maybe PortableRunner.java > should be moved to somewhere under sdks/java, as it's not actually a runner > itself. The nomenclature is confusing, PortableRunner could be more aptly > named something like `PortableRunnerClient`, or `JobClient` to better > illustrate its relationship with `JobServer`. > > On Tue, Oct 22, 2019 at 4:11 PM Michał Walenia <michal.wale...@polidea.com> > wrote: > >> Hi, >> >> I found the Java PortableRunner class in >> org.apache.beam.runners.reference package, where ReferenceRunner used to >> reside prior to its deletion. The PortableRunner implementation however is >> one that can be used with real JobServers in production code. >> >> >> It seems that this class shouldn’t be in the reference package but >> somewhere else. I’d like to rename the package from >> org.apache.beam.runners.reference to org.apache.beam.runners.portability, >> as it contains only classes related to the portable runner operation. >> >> >> What do you think? If nobody is strongly against the change, I’ll make a >> pull request with the refactor. >> >> >> Have a good day, >> >> Michal >> >> >> >> >> -- >> >> Michał Walenia >> Polidea <https://www.polidea.com/> | Software Engineer >> >> M: +48 791 432 002 <+48791432002> >> E: michal.wale...@polidea.com >> >> Unique Tech >> Check out our projects! <https://www.polidea.com/our-work> >> >
