Thanks all, 2/3 of PRs are merged (using _LOGGER). It should be pretty easy to switch the variable name to _log via sed. Best -P.
On Fri, Nov 15, 2019 at 2:08 PM Kyle Weaver <kcwea...@google.com> wrote: > +1 for per-module loggers (what Robert said). > > On Fri, Nov 15, 2019 at 1:48 PM Udi Meiri <eh...@google.com> wrote: > >> +1, but can we use something less verbose and shift key heavy than >> _LOGGER like log or _log? >> >> Also please dedupe with these existing bugs: >> https://issues.apache.org/jira/browse/BEAM-3523 >> https://issues.apache.org/jira/browse/BEAM-1825 >> >> On Thu, Nov 14, 2019 at 8:02 AM Thomas Weise <t...@apache.org> wrote: >> >>> Awesome, thanks Chad! >>> >>> On Wed, Nov 13, 2019 at 10:26 PM Chad Dombrova <chad...@gmail.com> >>> wrote: >>> >>>> Hi Thomas, >>>> >>>> >>>>> Will this include the ability for users to configure logging via >>>>> pipeline options? >>>>> >>>> >>>> We're working on a proposal to allow pluggable logging handlers that >>>> can be configured via pipeline options. For example, it would allow you to >>>> add a new logging handler for StackDriver or Elasticsearch. Will hopefully >>>> have a document to share soon. >>>> >>>> -chad >>>> >>>>