Shouldn't the runner only be needed at runtime? On Fri, Feb 5, 2021 at 10:09 AM Daniel Collins <[email protected]> wrote:
> Ah looks like its a bit harder than this. But I'll try to make it work for > building all of beam locally then get back to you with a working PR. > > On Fri, Feb 5, 2021 at 1:07 PM Daniel Collins <[email protected]> > wrote: > >> https://github.com/apache/beam/pull/13903 >> >> On Fri, Feb 5, 2021 at 12:48 PM Robert Bradshaw <[email protected]> >> wrote: >> >>> When we were using maven rather than gradle, it was impossible to make >>> the direct runner a dependency for core tests without making the direct >>> runner a dependency for core itself (which was cyclic). I would be super >>> happy if this got fixed; having to jump through hoops to run the majority >>> of core tests is a constant source of surprise. >>> >>> On Fri, Feb 5, 2021 at 9:34 AM Daniel Collins <[email protected]> >>> wrote: >>> >>>> Hello all, >>>> >>>> It looks like no tests in sdks/java/core will run if they need a runner >>>> (They'll use CrashingRunner instead), and if they are annotated >>>> with @Category(NeedsRunner.class), they will be excluded from the test >>>> rule. Does anyone know the reason for this? It appears rather old (> 3 >>>> years), but AFAICT adding the below in my local copy to dependencies and >>>> removing the test rule overrides allows these tests to run just fine. >>>> >>>> testCompile project(path: ":runners:direct-java", configuration: >>>> "shadow") >>>> >>>> -Daniel >>>> >>>>
