On Wed, Feb 10, 2021 at 11:56 AM Robert Bradshaw <[email protected]> wrote:
> Let's revert these content changes. > > On Wed, Feb 10, 2021 at 11:54 AM Kenneth Knowles <[email protected]> wrote: > >> On the "become a committer" page, the link to "our best practices" is a >> 404 to the old site. >> >> Under the header "Knows, upholds, and reinforces the responsibilities of >> an Apache Software Foundation committer" I am -1 to removing the details. >> The bullets we chose are not included in the linked ASF documentation, and >> we chose to highlight specific aspects. This is a significant content >> change that I do not think we should make. If the design idea is to >> declutter the page, the details should still exist on another page on the >> Beam site. >> > The broken link is actually supposed to go to a page that has the bullets (copied verbatim from the original I believe): http://test-beam.surge.sh/contribute/attributes/ There's a couple of things wrong here: - As you noted the link is broken, we probably just need to remove a beam.apache.org/ somewhere. - It's odd that this page is linked from within the best practices trait, as it actually includes details for all three major traits, including but not limited to best practices I could probably address the first item myself. Addressing the second one is a design question though. Maybe each trait should have a link to it's section in http://test-beam.surge.sh/contribute/attributes/ instead of some of them going to the ASF docs? I'd also be fine reverting the change if you still think that's the right approach. > >> Under the header "Knows, upholds, and reinforces the Apache Software >> Foundation code of conduct. To learn more see the ASF documentation." I am >> -0 to removing the details. Our bullets highlight specific aspects of the >> code of conduct. Specifically, we split up one of the items into separate >> bullet points, and we did not emphasize "be concise" or "step down >> considerately". I am OK going ahead with this change but want to note that >> this is a content change. >> >> Kenn >> >> On Wed, Feb 10, 2021 at 11:46 AM Robert Bradshaw <[email protected]> >> wrote: >> >>> +1 based on some basic browsing around. >>> >>> It would have been nice if the old and new site could have been >>> generated from the same content, to keep the old one around for a bit (if >>> needed, in that case we might have more confidence nothing was lost), but >>> probably not worth making and staging a copy. >>> >>> On Tue, Feb 9, 2021 at 12:45 PM Brittany Hermann <[email protected]> >>> wrote: >>> >>>> @Ahmet Altay <[email protected]> : Thank you for the suggestions to the >>>> Powered By page! I created two JIRA tickets for each of these. >>>> >>>> On Tue, Feb 9, 2021 at 11:34 AM Brian Hulette <[email protected]> >>>> wrote: >>>> >>>>> > Optional point: does it make sense to maintain a link to the old >>>>> Website from the new one for some time (in case something gets broken >>>>> in the new version or some information becomes unavailable) ? >>>>> >>>>> We could do this, but I think it would require duplicating all the >>>>> source for the existing website and putting it in a separate directory, >>>>> and >>>>> the content would slowly get out of date. I'm not sure it would be an >>>>> improvement - we'll have access to the current website in the >>>>> commit history anyway. >>>>> >>>>> Brian >>>>> >>>>> On Mon, Feb 8, 2021 at 4:44 PM Ahmet Altay <[email protected]> wrote: >>>>> >>>>>> +1 - I did a basic review looking around python docs and release >>>>>> guides mostly. >>>>>> >>>>>> One thing I would like to see fixed related to >>>>>> https://beam.apache.org/community/powered-by/ >>>>>> - New page is missing existing items from the current list >>>>>> https://beam.apache.org/community/powered-by/. Particularly I could >>>>>> not find TFX and Cloud Dataflow. >>>>>> - And a nice to have for that same page: New page could be >>>>>> simplified. There are a total of 8 powered by items and they are divided >>>>>> into two groups (1 click) and each group loads 3 items at a time (another >>>>>> click). I think it would be much more simple to list all 8 references on >>>>>> a >>>>>> single page. >>>>>> >>>>>> On Mon, Feb 8, 2021 at 2:39 PM Griselda Cuevas <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Great suggestion Cham. Noting it as optional. >>>>>>> >>>>>>> On Mon, 8 Feb 2021 at 13:51, Chamikara Jayalath < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> Thanks. This looks great. >>>>>>>> Optional point: does it make sense to maintain a link to the old >>>>>>>> Website from the new one for some time (in case something gets broken >>>>>>>> in >>>>>>>> the new version or some information becomes unavailable) ? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Cham >>>>>>>> >>>>>>>> On Mon, Feb 8, 2021 at 1:09 PM Pablo Estrada <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> +1 >>>>>>>>> I'm taking a superficial look through it as we speak. Thanks >>>>>>>>> everyone for the work : ) >>>>>>>>> >>>>>>>>> On Mon, Feb 8, 2021 at 9:32 AM Brian Hulette <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> +1, thank you Gris! >>>>>>>>>> >>>>>>>>>> I just wanted to add a note about my reviews here. I reviewed >>>>>>>>>> this change as a series of PRs that went into the website-revamp >>>>>>>>>> branch. My >>>>>>>>>> main focus in reviewing them was ensuring that no content was >>>>>>>>>> /unintentionally/ changed. >>>>>>>>>> >>>>>>>>>> Note that some content is intentionally changed and/or moved >>>>>>>>>> around as described in the designs Gris shared. Other content is >>>>>>>>>> separated >>>>>>>>>> out from markdown files into yaml files, I believe to aid future >>>>>>>>>> translation efforts. >>>>>>>>>> >>>>>>>>>> This makes it pretty tricky to verify the content based on the >>>>>>>>>> diff alone at this point, which is why I want to reassure the >>>>>>>>>> community >>>>>>>>>> that I had a particular focus on this in my reviews. I'm not perfect >>>>>>>>>> though! so more people looking over the changed pages will be great. >>>>>>>>>> >>>>>>>>>> Brian >>>>>>>>>> >>>>>>>>>> On Fri, Feb 5, 2021 at 9:13 PM Griselda Cuevas <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Everyone, >>>>>>>>>>> >>>>>>>>>>> The new designs for the Beam website are ready to be published >>>>>>>>>>> in PR #13871 [1], so I'd like to start a vote to merge this PR into >>>>>>>>>>> the >>>>>>>>>>> master repo. Considering that this PR could get stale very quickly, >>>>>>>>>>> we're >>>>>>>>>>> looking to follow the 72h voting period starting Monday, if there >>>>>>>>>>> are minor >>>>>>>>>>> bugs we will file them as Jira tickets so we can address them in >>>>>>>>>>> the next >>>>>>>>>>> refresh. >>>>>>>>>>> >>>>>>>>>>> This effort started back in November, when we kicked-off a >>>>>>>>>>> project to redesign a few critical pages of the Beam website, >>>>>>>>>>> primarily the >>>>>>>>>>> home page, a few of the community sections and the documentation >>>>>>>>>>> landing >>>>>>>>>>> page. >>>>>>>>>>> >>>>>>>>>>> Below you can find a summary of the changes and links to the >>>>>>>>>>> staged website for your review. >>>>>>>>>>> >>>>>>>>>>> Thank you, >>>>>>>>>>> G >>>>>>>>>>> >>>>>>>>>>> *What do I need to vote for? * >>>>>>>>>>> To merge PR #13871 [1] into master. This PR has been reviewed by >>>>>>>>>>> Brian H and Gris C (committers). You can see the staged version of >>>>>>>>>>> the >>>>>>>>>>> website here [2], for mobile versions use the same link in your >>>>>>>>>>> mobile. >>>>>>>>>>> >>>>>>>>>>> You can see a summary of changed pages in this deck [3]. If you >>>>>>>>>>> want even more background, you can read the requirements document >>>>>>>>>>> here [4] >>>>>>>>>>> and the design document with copy and wireframes here [5]. >>>>>>>>>>> >>>>>>>>>>> *Where can I see how the new designs look?* >>>>>>>>>>> You can see a staged version here [2], for mobile versions use >>>>>>>>>>> the same link in your mobile. >>>>>>>>>>> >>>>>>>>>>> *Why was this redesign made?* >>>>>>>>>>> This redesign was phase II of a long-term effort to make the >>>>>>>>>>> Apache Beam website more effective for users who want to learn >>>>>>>>>>> about Apache >>>>>>>>>>> Beam, implement it and contribute to the open source project. This >>>>>>>>>>> phase >>>>>>>>>>> was focused on improving resources for two types of users: 1) those >>>>>>>>>>> looking >>>>>>>>>>> to understand what Apache Beam is and to make the decision to adopt >>>>>>>>>>> it and >>>>>>>>>>> 2) those looking to make their first contribution to the OSS >>>>>>>>>>> project. >>>>>>>>>>> >>>>>>>>>>> *What changes in this redesign?* >>>>>>>>>>> We redesign 8 pages, including the home page, and created 3 new >>>>>>>>>>> sections, see more details here [3]. >>>>>>>>>>> >>>>>>>>>>> Links: >>>>>>>>>>> [1] https://github.com/apache/beam/pull/13871 >>>>>>>>>>> [2] http://test-beam.surge.sh/ >>>>>>>>>>> [3] >>>>>>>>>>> https://docs.google.com/presentation/d/1WcBccS4Bt6ZAEkw-nsud2MjU4H0j_iOkIk5XlPDk8f0/edit#slide=id.p >>>>>>>>>>> [4] >>>>>>>>>>> https://docs.google.com/document/d/1rssE8B6fvwLfyODS6KKp049KryhKn8E-HlHkzM8TWkE/edit >>>>>>>>>>> [5] >>>>>>>>>>> https://docs.google.com/document/d/1DDk8DtYGzuTO7bdu2nqiVEgVnx06lCzZ2idVpwcemFA/edit?resourcekey=0-KGE8dMg8L4j5rcqnQ5SG_g >>>>>>>>>>> >>>>>>>>>>> And lastly, HUGE THANK YOU to the team who contributed to these >>>>>>>>>>> changes (in alphabetical order): Agnieszka Sell, Brian Hulette, >>>>>>>>>>> Brittany >>>>>>>>>>> Hermann, David Cavazos, Gris Cuevas, Jakub Sadowski, Kasia Zajac, >>>>>>>>>>> Kenn >>>>>>>>>>> Knowles, Milka Toikkanen, Nam Bui, Rose Nguyen. >>>>>>>>>>> >>>>>>>>>>> >>>> >>>> -- >>>> >>>> Brittany Hermann >>>> >>>> Open Source Program Manager (Provided by Adecco Staffing) >>>> >>>> 1190 Bordeaux Drive , Building 4, Sunnyvale, CA 94089 >>>> <https://www.google.com/maps/search/1190+Bordeaux+Drive+,+Building+4,+Sunnyvale,+CA+94089?entry=gmail&source=g> >>>> >>>> >>>>
