I definitely think we should freeze until we have precommits re-enabled. We have a hypothesis that https://github.com/apache/beam/pull/21821 may reduce the impact on the Jenkins master. We would lose phrase triggering on postcommits, but we would still have it on precommits for retriggering after flakes.
Kenn On Sun, Jun 12, 2022 at 9:04 PM Chamikara Jayalath <chamik...@google.com> wrote: > Should we install a code commit freeze till this is addressed to maintain > code health ? I noticed that it's easy to miss certain untriggered test > suites for new PRs. > > Thanks, > Cham > > On Sun, Jun 12, 2022 at 5:25 PM Danny McCormick <dannymccorm...@google.com> > wrote: > >> In case anyone else is planning on taking a look at this, I did a deep >> dive on it and wrote up my findings here - >> https://docs.google.com/document/d/10qyUsvB_uVy5jftfTiwohlvN8Qwix5AuadssyoC4JsE/edit?usp=sharing >> >> My high level takeaways were: >> 1. I don't think this is actually caused by Issues, I think it's a >> structural issue with the plugin. At worst, Issues very minorly contributed >> to it (with a smaller impact than adding an extra build trigger would/did), >> but I'm not even sure that is true. As a result, our fix probably needs to >> focus on patching or switching to a new plugin. 2. Patching the plugin >> would be hard. >> 3. I agree that switching to a different plugin is the best path forward. >> >> If anyone else is looking into this and wants edit permissions on the >> doc, let me know! >> >> Thanks, >> Danny >> >> On Fri, Jun 10, 2022 at 5:21 PM Kiley Sok <kiley...@google.com> wrote: >> >>> There's currently an issue with too many connections from Jenkins to >>> Github bringing down Jenkins. The hypothesis is that we were already close >>> to the limit, but the extra triggers from GH issues pushed it over the edge. >>> >>> We're looking to switch to a different plugin that'll hopefully resolve >>> the issue. >>> >>> More info: https://issues.apache.org/jira/browse/INFRA-23358 and in >>> INFRA slack channel. >>> >>> Thanks for your patience! >>> >>
