+1 (binding) Kenn
On Wed, Apr 3, 2024 at 12:58 PM Danny McCormick via dev <dev@beam.apache.org> wrote: > > Also noting that there is no PR postsubmit test suite running against > the release branch in the vote email. Given the diff, that's also fine > since previous tests runs didn't detect the breakage, but in general we > should include that for patch releases as well. > > Yeah, it didn't seem useful to run these given the diff since they test > the code, not the produced artifacts (which is more or less our only vector > for new bugs here). If anyone disagrees I can kick that off, but deflaking > seems like more trouble than its worth > > ------------------------------------------------------------------------- > > Also, from my original email: This release does not include any website > changes since it is addressing a single bug fix as discussed in > https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. > I realized it is still worth making the website changes to get the > versions correct, even though no content will be updated. With that in > mind, I've also proposed changes to the beam-site [1] and the beam website > [2]. I still omitted writing a blog post. > > Thanks, > Danny > > [1] https://github.com/apache/beam-site/pull/663 > [2] https://github.com/apache/beam/pull/30839 > > On Wed, Apr 3, 2024 at 12:30 PM Valentyn Tymofieiev <valen...@google.com> > wrote: > >> Hi Danny, >> >> Thanks for volunteering to do this patch release. >> >> For review convenience, this is the diff: >> - Diff of release branches: >> https://github.com/apache/beam/compare/release-2.55.0...release-2.55.1 >> - The diff of tags v2.55.0-RC3 and v2.55.1-RC2: >> https://github.com/apache/beam/compare/v2.55.0-RC3...v2.55.1-RC2 is >> somewhat misleading, it looks as though there is a change in the version >> naming pattern, but upon inspection of gradle.properties for each tag >> individually, the pattern is the same and doesn't include dev/SNAPSHOT >> suffixes. >> >> > I put together a patch release per the conversation in >> https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. >> >> Noting that the 2.55.1 doesn't fix another Python SDK known issue that >> was called out in that thread, which is fine with me, just calling out the >> difference from previous discussion. >> >> Also noting that there is no PR postsubmit test suite running against the >> release branch in the vote email. Given the diff, that's also fine since >> previous tests runs didn't detect the breakage, but in general we should >> include that for patch releases as well. >> >> +1. Spot-checked some Python SDK artifacts and containers. >> >> On Wed, Apr 3, 2024 at 8:08 AM Danny McCormick via dev < >> dev@beam.apache.org> wrote: >> >>> Hi everyone, >>> >>> I put together a patch release per the conversation in >>> https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. >>> >>> Please review and vote on the release candidate #2 (I messed up rc1) for >>> the version 2.55.1, as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> Reviewers are encouraged to test their own use cases with the release >>> candidate, and vote +1 if no issues are found. Only PMC member votes will >>> count towards the final vote, but votes from all community members is >>> encouraged and helpful for finding regressions; you can either test your >>> own use cases [9] or use cases from the validation sheet [7]. >>> >>> The complete staging area is available for your review, which includes: >>> * the official Apache source release to be deployed to dist.apache.org >>> [1], which is signed with the key with fingerprint D20316F712213422 [2], >>> * all artifacts to be deployed to the Maven Central Repository [3], >>> * source code tag "v2.55.1-RC2" [4], >>> * Python artifacts are deployed along with the source release to the >>> dist.apache.org [1] and PyPI[5]. >>> * Go artifacts and documentation are available at pkg.go.dev [6] >>> * Validation sheet with a tab for 2.55.1 release to help with validation >>> [7]. >>> * Docker images published to Docker Hub [8]. >>> >>> This release does not include any website changes since it is addressing >>> a single bug fix as discussed in >>> https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> For guidelines on how to try the release in your projects, check out our >>> RC testing guide [9]. >>> >>> Thanks, >>> Danny >>> >>> [1] https://dist.apache.org/repos/dist/dev/beam/2.55.1/ >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS >>> [3] >>> https://repository.apache.org/content/repositories/orgapachebeam-1375/ >>> [4] https://github.com/apache/beam/tree/v2.55.1-RC2 >>> [5] https://pypi.org/project/apache-beam/2.55.1rc2/ >>> [6] >>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.55.1-RC2/go/pkg/beam >>> [7] >>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=686075626 >>> [8] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>> [9] >>> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md >>> >>
