[ 
https://issues.apache.org/jira/browse/BIGTOP-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474552#comment-13474552
 ] 

Johnny Zhang edited comment on BIGTOP-740 at 10/11/12 10:18 PM:
----------------------------------------------------------------

the solution I have right now is hard code a list of substring we want to trim 
from the file names, like "-amd64-64", "-i386-32". 

But it might not be a good idea when it comes to dependency version case (like 
python 2.4/2.6). As we don't want to hard code and maintain such a list in the 
code.
                
      was (Author: dreambird):
    the solution I have right now is hard code a list of patterns we want to 
trim from the file names, like "-amd64-64", "-i386-32". 

But it might not be a good idea when it comes to dependency version case (like 
python 2.4/2.6). As we don't want to hard code and maintain such a list in the 
code.
                  
> improve the package file content tests to ignore platform specific file names
> -----------------------------------------------------------------------------
>
>                 Key: BIGTOP-740
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-740
>             Project: Bigtop
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 0.5.0
>            Reporter: Johnny Zhang
>            Assignee: Johnny Zhang
>             Fix For: 0.5.0
>
>
> right now the package file content test recognize below files are different 
> and report errors
> {noformat}
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-amd64-64 (in centos5_x64)
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-i386-32 (in centos6_x32)
> ......
> /usr/lib64/libhdfs.so (in centos5_x64)
> /usr/lib/libhdfs.so (in centos6_x32)
> {noformat}
> the test should ignore those kind of difference, as they are platform 
> specific name.
> there is another type of file name difference we should ignore is the 
> dependency version. For example, the hue-common package detect the python 
> version installed on the OS and install correspond version of python related 
> file, for example
> {noformat}
> /usr/share/hue/build/env/bin/pip-2.4  (in centos5)
> /usr/share/hue/build/env/bin/pip-2.6  (in centos6)
> {noformat}
> those diff also should be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to