[
https://issues.apache.org/jira/browse/BIGTOP-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476633#comment-13476633
]
Johnny Zhang commented on BIGTOP-740:
-------------------------------------
a little explanations for the patch:
I make the change so the code will change file names in both golden meta and
runtime meta to the same uniform string. For example:
in golden meta, file name is
"/usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-amd64-64"
in runtime meta, file name is
"/usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-i386-32"
And the code change both of them into uniform string
"/usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-BIT-VERSION" so they will
match during comparison.
@Roman, This change will also let code change uniformed string in the debug
file in target dir. For example, the content of 'hadoop-0.20-mapreduce.xml'
generated in the target dir will looks like
{noformat}
......
<file name='/usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-BIT-VERSION'
owners='-1' perm='lrwxrwxrwx' user='root' group='root'
target='/usr/lib/hadoop/lib/native' />
......
{noformat}
the reason we cannot convert all "i386" string to "amd64" or convert all
"/usr/lib64/libhdfs" to "/usr/lib/libhdfs" string is because it will change
other pkg's right files names into incorrect ones. So, change both into a
uniform string like "BIT-VERSION" is a better solution.
> improve the package file content tests to ignore platform specific file names
> -----------------------------------------------------------------------------
>
> Key: BIGTOP-740
> URL: https://issues.apache.org/jira/browse/BIGTOP-740
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.5.0
> Reporter: Johnny Zhang
> Assignee: Johnny Zhang
> Fix For: 0.5.0
>
> Attachments: BIGTOP_740.txt
>
>
> right now the package file content test recognize below files are different
> and report errors
> {noformat}
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-amd64-64 (in centos5_x64)
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-i386-32 (in centos6_x32)
> ......
> /usr/lib64/libhdfs.so (in centos5_x64)
> /usr/lib/libhdfs.so (in centos6_x32)
> {noformat}
> the test should ignore those kind of difference, as they are platform
> specific name.
> there is another type of file name difference we should ignore is the
> dependency version. For example, the hue-common package detect the python
> version installed on the OS and install correspond version of python related
> file, for example
> {noformat}
> /usr/share/hue/build/env/bin/pip-2.4 (in centos5)
> /usr/share/hue/build/env/bin/pip-2.6 (in centos6)
> {noformat}
> those diff also should be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
