[ 
https://issues.apache.org/jira/browse/BIGTOP-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506641#comment-13506641
 ] 

Roman Shaposhnik commented on BIGTOP-793:
-----------------------------------------

Johnny, thanks a million for the patch! A couple of notes:
  # could you please attach your patches as git format-patch -- this makes it 
way easier for me to apply them
  # it seems that you have forgotten to include the 
bigtop-tests/test-execution/smokes/crunch/pom.xml
  # I suggest getting rid of crunchHome/crunchJar and have just a crunchJar 
with the default being /usr/share/doc/crunch*/crunch-examples-*-job.jar

Otherwise -- looks quite nice!
                
> add crunch integration tests
> ----------------------------
>
>                 Key: BIGTOP-793
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-793
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 0.5.0
>            Reporter: Roman Shaposhnik
>            Assignee: Johnny Zhang
>             Fix For: 0.5.0
>
>         Attachments: BIGTOP-793.text
>
>
> We need to provide tests that at least run crunch examples.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to