[ 
https://issues.apache.org/jira/browse/BIGTOP-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507013#comment-13507013
 ] 

Roman Shaposhnik commented on BIGTOP-793:
-----------------------------------------

Johnny,

a couple of points still.
  # I think it would be useful to have the location of the jar as a property 
(sorry if I wasn't clear before). Also, as you can see in my updated patch on 
BIGTOP-612 the correct location for examples is under 
/usr/share/doc/crunch*/crunch-examples-*job.jar. So something like the 
following would probably do us all good:
{noformat}
-  static String crunchJar = "/usr/lib/crunch/crunch-examples-*job.jar";
+  static String crunchJar = 
System.getProperty("org.apache.bigtop.itest.crunch.smoke.crunch.jar", 
"/usr/share/doc/crunch*/crunch-examples-*job.jar");
{noformat}
   # Somehow it seems that you don't quite manage to unpack your resources into 
the HDFS and the tests are failing for me on a real cluster. As a matter of 
fact, since unpacking of resources under a particular location (be it on HDFS 
or a host filesystem) is such a common operation I filed  BIGTOP-799 -- feel 
free to pick it up as part of fixing this one.
                
> add crunch integration tests
> ----------------------------
>
>                 Key: BIGTOP-793
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-793
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 0.5.0
>            Reporter: Roman Shaposhnik
>            Assignee: Johnny Zhang
>             Fix For: 0.5.0
>
>         Attachments: BIGTOP-793-2.patch.txt, BIGTOP-793.text
>
>
> We need to provide tests that at least run crunch examples.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to