[ 
https://issues.apache.org/jira/browse/BIGTOP-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590293#comment-13590293
 ] 

Bruno Mahé commented on BIGTOP-848:
-----------------------------------

I have not tested but it seems about right. Thanks a lot for the patch!
Some comments:
* Please comment out the 3 new lines in bigtop.mk and change the git URL to the 
Apache git repo. 
* if _$($(PKG)_GIT_LOC)_ is not defined, it should exit -1, not just exit. 
* Why not using the "git archive" which already does all the archiving for you?
                
> Allow to build stack on top of an arbitrary Hadoop SHA
> ------------------------------------------------------
>
>                 Key: BIGTOP-848
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-848
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.5.0
>            Reporter: Konstantin Boudnik
>         Attachments: 0001-initial-git-support-maybe.patch
>
>
> For the ease of experimenting and doing one-off stack builds, which was 
> always the objective of the founding idea of this project, I would like to 
> have a way to build a stack from an arbitrary SHA of Hadoop git.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to