[ 
https://issues.apache.org/jira/browse/BIGTOP-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603731#comment-13603731
 ] 

Roman Shaposhnik commented on BIGTOP-848:
-----------------------------------------

{noformat}
+       if [ -z $($(PKG)_LOC) ]; then $($(PKG)_LOC)=NONE; fi
+       if [ -z $($(PKG)_GIT_BRANCH) ]; then $($(PKG)_GIT_BRANCH)=master; fi
{noformat}

I'd recommend replacing this with the native make(1) way of doing things
(in package.mk):

{noformat}
diff --git a/package.mk b/package.mk
index 611eb5d..735c519 100644
--- a/package.mk
+++ b/package.mk
@@ -153,6 +153,12 @@ $(2)_PKG_NAME       ?= $$($(2)_NAME)
 # The default PKG_RELEASE will be 1 unless specified
 $(2)_RELEASE        ?= 1
 
+# The default remote location is NONE
+$(2)_LOG            ?= NONE
+
+# The default branch is master
+$(2)_GIT_BRANCH     ?= master
+
 $(2)_BUILD_DIR      = $(BUILD_DIR)/$(1)/
 $(2)_OUTPUT_DIR      = $(OUTPUT_DIR)/$(1)
 $(2)_SOURCE_DIR       = $$($(2)_BUILD_DIR)/source
{noformat}
                
> Allow to build stack on top of an arbitrary Hadoop SHA
> ------------------------------------------------------
>
>                 Key: BIGTOP-848
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-848
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.5.0
>            Reporter: Konstantin Boudnik
>             Fix For: 0.6.0
>
>         Attachments: 0001-BIGTOP-848-git-support-maybe.patch
>
>
> For the ease of experimenting and doing one-off stack builds, which was 
> always the objective of the founding idea of this project, I would like to 
> have a way to build a stack from an arbitrary SHA of Hadoop git.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to