[ 
https://issues.apache.org/jira/browse/BIGTOP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606597#comment-13606597
 ] 

Roman Shaposhnik commented on BIGTOP-12:
----------------------------------------

bq. bigtop-packages/src/common/hcatalog/hcatalog-server.default should not 
define HADOOP_PREFIX or HIVE_HOME. I see that HADOOP_HOME is a hack, but does 
it have to be in Apache HCatalog (incubating)?
bq. bigtop-packages/src/common/hcatalog/webhcat-server.default should not 
define HIVE_HOME or HADOOP_HOME
bq. bigtop-packages/src/common/hcatalog/hcatalog-server.svc. Can we name the 
pid in a consistent way? something like s/hcat.pid/hcatalog-server.pid/
bq. bigtop-packages/src/common/hcatalog/webhcat-server.svc. Can we name the pid 
in a consistent way? something like s/webhcat.pid/webhcat-server.pid/ or 
hcatalag-webhcat.pid

These 2 are an upstream HCatalog issues. I don't think we can workaround 
effectively in Bigtop. I filed HCATALOG-636 and also updated the patch to 
reference it.

bq. The man page does not have any reference to incubating/incubator. The man 
page also has some double spaces. Shouldn't also the copyright be updated?

Thanks. I fixed those. Not sure about double spaces -- it renders great by man. 
As for the date -- it looks like a policy with Linux man pages to list the 
starting one.

bq. In the wrapper script I still see the old way to use bigtop-detect-java 
home. I thought this was updated recently?

Great point. Fixed.

bq. bigtop-packages/src/deb/hcatalog/control still has some references to 
Apache Bigtop (incubating)
bq. bigtop-packages/src/deb/hcatalog/copyright, I believe that upstream name 
should contain (incubating)
bq. bigtop-packages/src/rpm/hcatalog/SPECS/hcatalog.spec. (incubating) is not 
mentioned in appropriate places.
bq. bigtop.mk. release notes variable should have (incubating)

Great point. Fixed.

bq. bigtop-packages/src/rpm/hcatalog/SPECS/hcatalog.spec. Should we give the 
same treatment than Apache Hadoop regarding the use of Requires(pre): hcatalog 
for the daemons packages?

I don't see what would be the danger. Do you know of any downside in always 
doing that?

                
> Add HCatalog to Bigtop
> ----------------------
>
>                 Key: BIGTOP-12
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-12
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Jolly Chen
>            Assignee: Giridharan Kesavan
>             Fix For: 0.3.1, 0.6.0
>
>         Attachments: 0001-BIGTOP-12.-Add-HCatalog-to-Bigtop.patch, 
> BIGTOP-12-V1.PATCH, BIGTOP-12-V2.PATCH, BIGTOP-12-V3.PATCH, 
> BIGTOP-12-V4.PATCH, BIGTOP-12-V5.PATCH, BIGTOP-12.V6.PATCH, 
> BIGTOP-12-V7.patch, hcatalog.patch
>
>
> adding HCatalog http://incubator.apache.org/hcatalog/ would enhance the 
> Bigtop platform
> for post 0.1.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to