[
https://issues.apache.org/jira/browse/BIGTOP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606603#comment-13606603
]
Roman Shaposhnik commented on BIGTOP-12:
----------------------------------------
bq. This appears to assume the presence of init.d.tmpl - is this intended to go
atop BIGTOP-805, or will those changes be back-ported into this patch first?
Great point. It does indeed go on top of BIGTOP-805. Cos, if you want this to
be in Bigtop 0.3.1 you'd also have to backport the bits of BIGTOP-805 that have
to do with init.d templating.
bq. Also (and this is more for my own curiosity than a review of your patch) -
does the default generate_stop() function work well for stopping HCatalog? I
hadn't looked very closely at the defaults for those functions because I had
assumed they were rather specific to the Hadoop daemons (hence having
overridden them for other daemons). But after a longer look through docs on
LSB's start_daemon (which seem a little scant and inconsistent), it seems that
either "stop" is a subcommand of start_daemon for which I can find no
documentation, or start_daemon is entirely the wrong choice here, and I'm
surprised it's working for Hadoop. Let's chat offline if my confusion is
irrelevant to the patch, but I just wanted to make sure `service
hcatalog-server stop` could be expected to work.
Hm. I see where you're coming from. This, however, appears to be more of a
generic question rather than related to this patch. Would you mind opening up a
new JIRA to address this concern about our init.d template?
> Add HCatalog to Bigtop
> ----------------------
>
> Key: BIGTOP-12
> URL: https://issues.apache.org/jira/browse/BIGTOP-12
> Project: Bigtop
> Issue Type: Improvement
> Components: General
> Affects Versions: 0.1.0
> Reporter: Jolly Chen
> Assignee: Giridharan Kesavan
> Fix For: 0.3.1, 0.6.0
>
> Attachments: 0001-BIGTOP-12.-Add-HCatalog-to-Bigtop.patch,
> BIGTOP-12.bruno.feedback.txt, BIGTOP-12-V1.PATCH, BIGTOP-12-V2.PATCH,
> BIGTOP-12-V3.PATCH, BIGTOP-12-V4.PATCH, BIGTOP-12-V5.PATCH,
> BIGTOP-12.V6.PATCH, BIGTOP-12-V7.patch, hcatalog.patch
>
>
> adding HCatalog http://incubator.apache.org/hcatalog/ would enhance the
> Bigtop platform
> for post 0.1.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
