[
https://issues.apache.org/jira/browse/BIGTOP-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768595#comment-13768595
]
jay vyas commented on BIGTOP-1032:
----------------------------------
1) Regarding the Architecture this makes sense to me: IT will be super nice to
modularize the tests, as this is a very complicated and long test suite . And
bigtop has the advantage of moving faster than hadoop, so it can layer over the
tests with more modular logic without having to directly modify them too much.
2) Usefullness: And also To confirm that this is possible to control through
maven alone we can see the excludeGroups option:
http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#excludedGroups
.
3) Implementation: A minor suggestion : Instead of System.getProperty (in
TestCLI.java above") . Why not just read from HADOOP_CONF_DIR which should be
set in any bigtop test? That would follow the idiom that all the other smokes/
follow.
And by the way [~mbukatov] if you want to put your code in a github fork it
might be easier for us to monitor your progres on this until your patch is
ready :) :) :)
THANKS ! Can't wait to use these modularized hdfs vs hcfs tests on our
clusters.
> Refactor hdfs/TestCLI and hdfs/TestAppend to be generic filesystem tests
> -------------------------------------------------------------------------
>
> Key: BIGTOP-1032
> URL: https://issues.apache.org/jira/browse/BIGTOP-1032
> Project: Bigtop
> Issue Type: Improvement
> Reporter: jay vyas
> Attachments: FSCmdExecutor.java, TestCLI.java
>
>
> The TestCLI and TestAppend classes both have hard references to an HDFS user
> shell, although most of their functionality is actually geared towards
> testing the abstract FileSystem interface.
> Removing a couple of lines from TestCLI:
> String[] createTestcliDirCmds = {"hadoop fs -mkdir -p " +
> TEST_DIR_ABSOLUTE,
> "hadoop fs -chmod 777 " + TEST_DIR_ABSOLUTE};
> shHDFS.exec(createTestcliDirCmds);
> And a this line from TestAppend:
> shHDFS.exec("hadoop fsck
> /user/$USERNAME/$testAppendInput/test2.file$date");
> This will essentially allow bigtop suites to be used to validate file system
> functionality in clusters with heterogenous
> https://wiki.apache.org/hadoop/HCFS/ implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
