[ 
https://issues.apache.org/jira/browse/BIGTOP-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878368#comment-13878368
 ] 

Peter Linnell commented on BIGTOP-1179:
---------------------------------------

Minor nits:

Recommends for ntp ?   Why not make it a dependency  ?   Just curious..

Please wrap %description at 69 chars.  It  makes reading it in the rpm gui 
tools a lot nicer. In fact nothing in an rpm spec should exceed 69 chars.  I 
know I know... It is a style thing ;)

please /bin/bash not bin/sh and declare if for the debian variants.  We've long 
standardized on bash for the shell.

Otherwise if my eyes do not fail me looks good and +1 for including it.

> Add Apache Tez to bigtop
> ------------------------
>
>                 Key: BIGTOP-1179
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1179
>             Project: Bigtop
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Giridharan Kesavan
>            Assignee: Giridharan Kesavan
>         Attachments: 0001-BIGTOP-1179.-Add-Apache-Tez-to-bigtop.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to