[ 
https://issues.apache.org/jira/browse/BIGTOP-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884808#comment-13884808
 ] 

Konstantin Boudnik edited comment on BIGTOP-1192 at 1/29/14 2:51 AM:
---------------------------------------------------------------------

- expecting passwordless slogin as root in a system is too much to ask, in my 
opinion. Even development machines won't be lax'd like that. I'd suggest to 
expect a passwrodless sudo for certain commands for a specific user (e.g. 
jenkins, testuser).
- usability wise, it would be good if test can make some assumptions about the 
location of the identity file, e.g. {{~/.ssh/id_dsa}} or {{~/.ssh/id_rsa}} 
instead of always forcing the setting of the env variable. In other words, if 
the can be found in the standard location - let's try to run the unit test with 
it. Otherwise, fall-back to the current approach
- test requirements need to be expressed upfront, e.g. in a README file or else
- asserts should have meaningful messages
- Minor formatting comment: there should be empty lines around ASL license URL 
(e.g. http://www.apache.org/licenses/LICENSE-2.0.html)




was (Author: cos):
- expecting passwordless slogin as root in a system is too much to ask, in my 
opinion. Even development machines won't be lax'd like that. I'd suggest to 
expect a passwrodless sudo for certain commands for a specific user (e.g. 
jenkins, testuser).
- test requirements need to be expressed upfront, e.g. in a README file or else
- asserts should have meaningful messages
- Minor formatting comment: there should be empty lines around ASL license URL 
(e.g. http://www.apache.org/licenses/LICENSE-2.0.html)



> Add utilities to facilitate cluster failure testing into bigtop-test-framework
> ------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1192
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1192
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>              Labels: bigtop, itest, smokes
>             Fix For: 0.8.0
>
>         Attachments: BIGTOP-1192.1.patch
>
>
> The goal is to provide Bigtop module maintainers with a set of set of util 
> classes to help develop smoke tests able to simulate certain failures during 
> smoke tests execution on a cluster.
> Summary of what is provided in current patch. 
> Following failure types are supported now:
>  - Service stopped and restarted (on given set of nodes)
>  - Service killed with 'kill -9' and started back up (on given set of nodes)
>  - Node inbound/outbound connections are shut down and brought back up (via 
> iptables).
>  
> System requirements to run smoke tests with failures.
>  *  password-less (PKI-based) root ssh to all nodes in cluster being tested 
> is assumed.
>  *  for local tests, like ClusterFailuresTest, one should have password-less 
> root ssh to localhost.
>  *  env variable BIGTOP_SMOKES_CLUSTER_IDENTITY_FILE should point to 
> according private key file.
> Further thoughts (not included in this patch)
>   Cluster provisioning
>    - Bigtop test framework (failures part of it) doesn't need to know about 
> cluster topology, as it simply executes set of SSH commands on remote hosts 
> (whose addresses are provided by specific
>    module smoke test developer). But the actual tests do need to know about 
> cluster topology to run sophisticated failure scenarios.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to