[
https://issues.apache.org/jira/browse/BIGTOP-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888100#comment-13888100
]
Konstantin Boudnik commented on BIGTOP-1199:
--------------------------------------------
Patch works overall - thanks for stepping in!. A couple of comments:
- it has a side effect of re-downloading the source archive each time unless
both .zip and .tar.gz files are present
- once the build is over, it left a tiny talball in
{{dl/groovy-binary-2.2.1.tar.gz}} and repackaged tarball in
{{dl/groovy-binary-2.2.1.tar.gz}}; The former fails the consequent build
attempt.
> Makefile for deb packing needs to support zip archives
> ------------------------------------------------------
>
> Key: BIGTOP-1199
> URL: https://issues.apache.org/jira/browse/BIGTOP-1199
> Project: Bigtop
> Issue Type: Bug
> Components: General
> Affects Versions: 0.7.0
> Reporter: Konstantin Boudnik
> Assignee: Roman Shaposhnik
> Priority: Blocker
> Fix For: 0.8.0
>
> Attachments:
> 0001-BIGTOP-1199.-Makefile-for-deb-packing-needs-to-suppo.patch
>
>
> At the moment it isn't possible to build debian packages if the source
> archive comes in the form of .zip file. The makes file is failing as gzip
> can't deal with zip file. E.g in case of bigtop-groovy package the log looks
> like this:
> {noformat}
> if [ -n "groovy-binary-2.2.1.zip" ]; then \
> cp /biggy/workspaces/bigtop/dl/groovy-binary-2.2.1.zip
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy_2.2.1.orig.tar.gz
> ;\
> cd
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy-2.2.1 && \
> tar --strip-components 1 -xvf ../bigtop-groovy_2.2.1.orig.tar.gz;\
> else \
> tar -czf
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy_2.2.1.orig.tar.gz
> LICENSE ;\
> fi
> gzip: stdin has more than one entry--rest ignored
> tar: Child returned status 2
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
