[ 
https://issues.apache.org/jira/browse/BIGTOP-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896912#comment-13896912
 ] 

Konstantin Boudnik commented on BIGTOP-1199:
--------------------------------------------

There's a couple of ways to reproduce the issue:
{noformat}
% make realclean
% make bigtop-groovy-rpm
## zip file is getting downloaded and everything builds fine
## there are dl/groovy-binary-2.2.1.tar.gz.orig (zip format) and 
dl/groovy-binary-2.2.1.tar.gz (tar.gz)
% make clean bigtop-groovy-rpm
## fails as unzip fails now
{noformat}

Exactly same behavior is observable in case of deb creation. So, there are some 
extra file movements happening around the zip file, that are screwing up the 
setup. 

The patch in current form works if I manually delete {{dl/groovy*}}. It 
triggers re-downloading of the zip archive and process is moving forward just 
fine. Perhaps, this is an acceptable first iteration of the patch and it 
unblocks BIGTOP-1097 for now. However, we should fix it sooner than later, 
because the build process will now inadvertently require a real clean process 
in between of the runs. 

I am ok with +1'ing this patch, committing it, and opening a separate bug issue 
to fix the glitch, if this is something we want to do to unblock the progress 
on groovy-package JIRA.

> Makefile for deb packing needs to support zip archives
> ------------------------------------------------------
>
>                 Key: BIGTOP-1199
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1199
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.7.0
>            Reporter: Konstantin Boudnik
>            Assignee: Roman Shaposhnik
>            Priority: Blocker
>             Fix For: 0.8.0
>
>         Attachments: 
> 0001-BIGTOP-1199.-Makefile-for-deb-packing-needs-to-suppo.patch
>
>
> At the moment it isn't possible to build debian packages if the source 
> archive comes in the form of .zip file. The makes file is failing as gzip 
> can't deal with zip file. E.g in case of bigtop-groovy package the log looks 
> like this:
> {noformat}
> if [ -n "groovy-binary-2.2.1.zip" ]; then \
>           cp /biggy/workspaces/bigtop/dl/groovy-binary-2.2.1.zip 
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy_2.2.1.orig.tar.gz
>  ;\
>           cd 
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy-2.2.1 && \
>             tar --strip-components 1 -xvf ../bigtop-groovy_2.2.1.orig.tar.gz;\
>         else \
>                  tar -czf 
> /biggy/workspaces/bigtop/build/bigtop-groovy//deb/bigtop-groovy_2.2.1.orig.tar.gz
>  LICENSE ;\
>         fi
> gzip: stdin has more than one entry--rest ignored
> tar: Child returned status 2
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to