> On Feb. 20, 2014, 11:16 p.m., Mark Grover wrote: > > bigtop-packages/src/common/hadoop/httpfs-tomcat-deployment.sh, line 10 > > <https://reviews.apache.org/r/18324/diff/1/?file=499487#file499487line10> > > > > Not a deal breaker but I cringe at the thought of a directory being > > removed and created by this script. > > > > I would personally prefer removing the contents of that directory and > > delivering that directory via a package. > > > > Seems like a personal preference to me but maybe some other packaging > > gurus have a reason why one would want to do it one way over the other.
It's definitely no worse than the status-quo, and I'd argue this is perfectly normally since it's run-time state (analogous to /work/ and other directories that get destroyed / created at run-time already) that's inside a directory created and owned by the package. I intended the script to be usable on tmpfs partitions as well - which is what I'll most likely do to support the tooling in Sqoop 2 that requires it's own CATALINA_BASE that isn't long-lived. > On Feb. 20, 2014, 11:16 p.m., Mark Grover wrote: > > bigtop-packages/src/common/sqoop/tomcat-deployment.sh, line 11 > > <https://reviews.apache.org/r/18324/diff/1/?file=499497#file499497line11> > > > > Also, there seems to be some code duplication in these scripts. Would > > love to hear if you have any ideas on refactoring to avoid that! > > > > Also, feel free to do that in a follow-up JIRA in order to not make the > > testing any more involved here. Possibly - but again it's already an improvement over the status quo as we're down to 1 copy per component. There are enough minor differences between some of the scripts and potential for more in the future that I'm pretty sure having more of this shared between all components will only make it more complicated. - Sean ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18324/#review35101 ----------------------------------------------------------- On Feb. 20, 2014, 10:08 p.m., Sean Mackrory wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18324/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 10:08 p.m.) > > > Review request for bigtop. > > > Bugs: BIGTOP-1215 > https://issues.apache.org/jira/browse/BIGTOP-1215 > > > Repository: bigtop > > > Description > ------- > > See JIRA. > > > Diffs > ----- > > bigtop-packages/src/common/hadoop/hadoop-httpfs.svc > 13125f350f2f6caf1d0c36912624c610182e08b2 > bigtop-packages/src/common/hadoop/httpfs-tomcat-deployment.sh PRE-CREATION > bigtop-packages/src/common/hadoop/install_hadoop.sh > fe004a106c673e0beaa7039d2831b10ba72d9825 > bigtop-packages/src/common/oozie/install_oozie.sh > efddce08b866b1c38be2f2d0e2bbe2f0f2a6d290 > bigtop-packages/src/common/oozie/oozie.init > d5a8dc9d9902389193b9401c040d35eaf7ef3f44 > bigtop-packages/src/common/oozie/tomcat-deployment.sh PRE-CREATION > bigtop-packages/src/common/solr/install_solr.sh > 28350fc48bf7aa49956507d35cf25bdffdd9936f > bigtop-packages/src/common/solr/solr-server.init.debian > f24dd396b4af70310dc64a23eb7c3140555031ca > bigtop-packages/src/common/solr/tomcat-deployment.sh PRE-CREATION > bigtop-packages/src/common/sqoop/install_sqoop.sh > 19468fbe4c1d7d2a609afaceeae63c34bde9bfc0 > bigtop-packages/src/common/sqoop/sqoop-server.sh > d7bf00b2f89c40be80f8439c5159815b67af0c08 > bigtop-packages/src/common/sqoop/tomcat-deployment.sh PRE-CREATION > bigtop-packages/src/deb/hadoop/hadoop-httpfs.postinst > ed9a9cdb6e9a4ad0bca21e0dbde4fe988a0c29ba > bigtop-packages/src/deb/hadoop/hadoop-httpfs.prerm > 2f4cf101135bb2ba036f3272b39ec3c91bc2aafe > bigtop-packages/src/deb/oozie/oozie.postinst > 5bd0dd1f6b36554f1a4d3f394beb3426a767f091 > bigtop-packages/src/deb/solr/solr.postinst > 7b768d8d5eb86f568b53216b9db46cc3aa945fb4 > bigtop-packages/src/deb/solr/solr.prerm > 2c9053b5134966d914dc8834694943ee73aaa44e > bigtop-packages/src/deb/sqoop/sqoop.install > a235d84716fe7328a4d54d851d3dfdee356ce086 > bigtop-packages/src/deb/sqoop/sqoop.postinst > 2af541db7d660023ec6bd3f2474f285ebf32b22a > bigtop-packages/src/deb/sqoop/sqoop.prerm > d4a25b9a126b058d6c95ac83f32dd18a96de8181 > bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec > 158d0905fa8a21ae6a1f0f2464c5f0e3e36d0370 > bigtop-packages/src/rpm/oozie/SPECS/oozie.spec > 35e7824d4850de047d9bb34f24a1990c53dd7c59 > bigtop-packages/src/rpm/solr/SOURCES/solr-server.init > ff4654b825c5f66106324084efe7752af814bb76 > bigtop-packages/src/rpm/solr/SPECS/solr.spec > d7b0e686646a7186859e6d32fcbfdc42f1cb7084 > bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec > a2d02bb6a13d15cbb366ebd63a3a1527e9fc7892 > > Diff: https://reviews.apache.org/r/18324/diff/ > > > Testing > ------- > > Built, installed, started, status checked, stopped status checked Hadoop + > HttpFS, Solr, Oozie and Sqoop on Ubuntu 12.04 and SLES 11. Submitted HTTP > requests through HttpFS, checked Solr for the bug where it looped through > /work/ directories infinitely, checked that Oozie served up web pages over > both HTTP and HTTPS, and pinged the server for a version check in Sqoop. > Checked that installed configuration directories looked correct and > consistent. > > > Thanks, > > Sean Mackrory > >
