> On Feb. 21, 2014, 8:07 p.m., Mark Grover wrote:
> > bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec, line 167
> > <https://reviews.apache.org/r/18324/diff/1-2/?file=499506#file499506line167>
> >
> >     Any particular reason why we are calling this file 
> > httpfs-tomcat-deployment.sh instead of tomcat-deployment.sh like we do for 
> > other components?

Yes there is, actually. Hadoop is the only one of the 4 components that has 
multiple daemons, and that splits those daemons up into multiple subdirectories 
of /usr/lib, so I thought it more important to be specific about what the 
source file was for, exactly. Although HttpFS is the only one of those daemons 
that's hosted on Tomcat, without having the source file named specifically for 
HttpFS we'd have this situation:

common/hadoop/tomcat-deployment.sh -> 
/usr/lib/hadoop-httpfs/tomcat-deployment.sh
common/oozie/tomcat-deployment.sh -> /usr/lib/oozie/tomcat-deployment.sh
common/solr/tomcat-deployment.sh -> /usr/lib/solr/tomcat-deployment.sh
common/sqoop/tomcat-deployment.sh -> /usr/lib/sqoop/tomcat-deployment.sh


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18324/#review35188
-----------------------------------------------------------


On Feb. 21, 2014, 7:54 p.m., Sean Mackrory wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18324/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 7:54 p.m.)
> 
> 
> Review request for bigtop.
> 
> 
> Bugs: BIGTOP-1215
>     https://issues.apache.org/jira/browse/BIGTOP-1215
> 
> 
> Repository: bigtop
> 
> 
> Description
> -------
> 
> See JIRA.
> 
> 
> Diffs
> -----
> 
>   bigtop-packages/src/common/hadoop/hadoop-httpfs.svc 
> 13125f350f2f6caf1d0c36912624c610182e08b2 
>   bigtop-packages/src/common/hadoop/httpfs-tomcat-deployment.sh PRE-CREATION 
>   bigtop-packages/src/common/hadoop/install_hadoop.sh 
> fe004a106c673e0beaa7039d2831b10ba72d9825 
>   bigtop-packages/src/common/oozie/install_oozie.sh 
> efddce08b866b1c38be2f2d0e2bbe2f0f2a6d290 
>   bigtop-packages/src/common/oozie/oozie.init 
> d5a8dc9d9902389193b9401c040d35eaf7ef3f44 
>   bigtop-packages/src/common/oozie/tomcat-deployment.sh PRE-CREATION 
>   bigtop-packages/src/common/solr/install_solr.sh 
> 28350fc48bf7aa49956507d35cf25bdffdd9936f 
>   bigtop-packages/src/common/solr/solr-server.init.debian 
> f24dd396b4af70310dc64a23eb7c3140555031ca 
>   bigtop-packages/src/common/solr/tomcat-deployment.sh PRE-CREATION 
>   bigtop-packages/src/common/sqoop/install_sqoop.sh 
> 19468fbe4c1d7d2a609afaceeae63c34bde9bfc0 
>   bigtop-packages/src/common/sqoop/sqoop-server.sh 
> d7bf00b2f89c40be80f8439c5159815b67af0c08 
>   bigtop-packages/src/common/sqoop/tomcat-deployment.sh PRE-CREATION 
>   bigtop-packages/src/deb/hadoop/hadoop-httpfs.postinst 
> ed9a9cdb6e9a4ad0bca21e0dbde4fe988a0c29ba 
>   bigtop-packages/src/deb/hadoop/hadoop-httpfs.prerm 
> 2f4cf101135bb2ba036f3272b39ec3c91bc2aafe 
>   bigtop-packages/src/deb/oozie/oozie.postinst 
> 5bd0dd1f6b36554f1a4d3f394beb3426a767f091 
>   bigtop-packages/src/deb/solr/solr.postinst 
> 7b768d8d5eb86f568b53216b9db46cc3aa945fb4 
>   bigtop-packages/src/deb/solr/solr.prerm 
> 2c9053b5134966d914dc8834694943ee73aaa44e 
>   bigtop-packages/src/deb/sqoop/sqoop.install 
> a235d84716fe7328a4d54d851d3dfdee356ce086 
>   bigtop-packages/src/deb/sqoop/sqoop.postinst 
> 2af541db7d660023ec6bd3f2474f285ebf32b22a 
>   bigtop-packages/src/deb/sqoop/sqoop.prerm 
> d4a25b9a126b058d6c95ac83f32dd18a96de8181 
>   bigtop-packages/src/rpm/hadoop/SPECS/hadoop.spec 
> 158d0905fa8a21ae6a1f0f2464c5f0e3e36d0370 
>   bigtop-packages/src/rpm/oozie/SPECS/oozie.spec 
> 35e7824d4850de047d9bb34f24a1990c53dd7c59 
>   bigtop-packages/src/rpm/solr/SOURCES/solr-server.init 
> ff4654b825c5f66106324084efe7752af814bb76 
>   bigtop-packages/src/rpm/solr/SPECS/solr.spec 
> d7b0e686646a7186859e6d32fcbfdc42f1cb7084 
>   bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 
> a2d02bb6a13d15cbb366ebd63a3a1527e9fc7892 
> 
> Diff: https://reviews.apache.org/r/18324/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, started, status checked, stopped status checked Hadoop + 
> HttpFS, Solr, Oozie and Sqoop on Ubuntu 12.04 and SLES 11. Submitted HTTP 
> requests through HttpFS, checked Solr for the bug where it looped through 
> /work/ directories infinitely, checked that Oozie served up web pages over 
> both HTTP and HTTPS, and pinged the server for a version check in Sqoop. 
> Checked that installed configuration directories looked correct and 
> consistent.
> 
> 
> Thanks,
> 
> Sean Mackrory
> 
>

Reply via email to