[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916941#comment-13916941
]
Konstantin Boudnik commented on BIGTOP-1221:
--------------------------------------------
- When you change the package of a class you actually better move the class as
well:
{noformat}
---
a/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy
+++
b/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy
@@ -15,7 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.bigtop.itest.hadoop.hdfs
+package org.apache.bigtop.itest.hadoop.hcfs
{noformat}
- declare types in the {{testWrapper}} as you know them
- remove commented out lines that seems like a leftovers from previous
experiments
- create javadoc for the testWrapper method
- there seems to be some inconsistency in how {{testWrapper}} is called. E.g.
looks like a parameter is missed here (testCd)
{noformat}
+ testWrapper(
+ "cd ${testdir} && pwd ",
+ {
{noformat}
- there are some overall inconsistencies in the identation: they are 2, 3, and
sometimes 4. Please follow the guidelines on that.
- not all asserts have messages
- there seems to be a number of unnecessary empty lines
- don't use printlns - a logger should be used instead
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Reporter: jay vyas
> Assignee: jay vyas
> Attachments: BIGTOP-1221.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
