[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918960#comment-13918960
]
Konstantin Boudnik commented on BIGTOP-1221:
--------------------------------------------
Thanks Jay. Some comments (mostly cosmetic):
- conceptually speaking: how this new test relates to the original
{{TestFuseDFS}}? Will it be a replacement to the original test? If so, the old
class should be gone as the part of the same patch
- as always - indentation is wrong
- in the {{testCp}} (and elsewhere) you use full paths inconsistently. Is there
a reason for that?
- there are some comments formatting issues that need to be addressed
-
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: jay vyas
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1221-cos-fixes.patch, BIGTOP-1221.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)