[ 
https://issues.apache.org/jira/browse/BIGTOP-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034450#comment-14034450
 ] 

Manikandan Narayanaswamy commented on BIGTOP-1337:
--------------------------------------------------

Missed adding the patch earlier, attaching now. Thanks Peter.

> Logging success messages in service startup and shutdown only after 
> verification.
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1337
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1337
>             Project: Bigtop
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Manikandan Narayanaswamy
>              Labels: packaging
>             Fix For: 0.8.0
>
>         Attachments: BIGTOP-1337.patch
>
>
> Right now, it appears like we log success messages right at the beginning of 
> the method call irrespective of whether the service was successfully stopped 
> / started. In a scenario where the user issues "service serviceName start" 
> and immediately sees a success message but, the service in reality has failed 
> to start leads to some amount of confusion.
> The proposed change will only log success messages if the operation was 
> actually successful.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to