[
https://issues.apache.org/jira/browse/BIGTOP-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040446#comment-14040446
]
Roman Shaposhnik commented on BIGTOP-1337:
------------------------------------------
[~mnarayan] thanks for the patch. The way it is posted it doesn't seem to
apply. It tries to patch Impala and Bigtop doesn't package it. Also the patch
seems to be touching:
{noformat}
error: bigtop-packages/src/common/hadoop/hadoop-hdfs-nfs3.svc: does not exist
in index
error: bigtop-packages/src/common/hbase-solr/hbase-solr-indexer.svc: does not
exist in index
error: bigtop-packages/src/common/sentry/sentry-store.svc: does not exist in
index
{noformat}
Is there any chance you can backport the missing packaging functionality as
well before applying this patch?
Feel free to file extra JIRAs for Hadoop NFS, Sentry store and whatever else is
missing.
> Logging success messages in service startup and shutdown only after
> verification.
> ---------------------------------------------------------------------------------
>
> Key: BIGTOP-1337
> URL: https://issues.apache.org/jira/browse/BIGTOP-1337
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Manikandan Narayanaswamy
> Assignee: Roman Shaposhnik
> Labels: packaging
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1337.patch
>
>
> Right now, it appears like we log success messages right at the beginning of
> the method call irrespective of whether the service was successfully stopped
> / started. In a scenario where the user issues "service serviceName start"
> and immediately sees a success message but, the service in reality has failed
> to start leads to some amount of confusion.
> The proposed change will only log success messages if the operation was
> actually successful.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
