[ 
https://issues.apache.org/jira/browse/BIGTOP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072590#comment-14072590
 ] 

Mark Grover commented on BIGTOP-1373:
-------------------------------------

Thanks Julien, I much prefer the separate make file. That way people who 
download Bigtop source and build a released version of, say HBase, can build it 
without making any code changes to the .mk file, while Bigtop jenkins, on the 
other hand, could hook on to HBase github and do a nightly build a different 
version of HBase, without any code changes as well.

If we went with same Makefile, code changes will definitely be required across 
these 2 use-cases because the BASE_VERSION is shared with them.

Your patch looks good to me, I will wait for a day or two for anyone to post 
their opinion and then go ahead and commit it.

Thanks for doing this! This is super valuable to the Bigtop community and goes 
a long way in helping us find integration problems in the ecosystem sooner!

> Add a mechanism of obtaining source for components from SCM
> -----------------------------------------------------------
>
>                 Key: BIGTOP-1373
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1373
>             Project: Bigtop
>          Issue Type: Improvement
>            Reporter: Julien Eid
>         Attachments: BIGTOP-1373-extrafile.patch, 
> BIGTOP-1373-noextrafile.patch, BIGTOP-1373.patch
>
>
> This was brought up here (https://issues.apache.org/jira/browse/BIGTOP-1363) 
> as a much wanted feature for our build system so we can build against 
> branches. I have two approaches to doing this that I'll be posting up Patch 
> files for and seeing which approach everyone likes better. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to