[ 
https://issues.apache.org/jira/browse/BIGTOP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075085#comment-14075085
 ] 

Konstantin Boudnik commented on BIGTOP-1373:
--------------------------------------------

I think my comment wasn't too clearly expressed. I am not advocating for having 
in-line changes in the existing {{bigtop.mk}}. In fact I am all for the 
'separation of concerns' approach. What I said is that we don't need to fully 
duplicate {{bigtop.mk => bigtop-github.mk}} and then forever make two set of 
changes we need to update a release version of a component.

Instead a way more surgical and elegant way of doing things is to _only_ put 
those components into {{bigtop-github.mk}} that one wants to pull off of 
github. During build defines from {{bigtop-github.mk}} will override  
{{bigtop.mk}} producing expected BOM. Did I expressed it better now?

BTW, JIRA isn't a right way to gauge communal preferences, IMO.

> Add a mechanism of obtaining source for components from SCM
> -----------------------------------------------------------
>
>                 Key: BIGTOP-1373
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1373
>             Project: Bigtop
>          Issue Type: Improvement
>            Reporter: Julien Eid
>         Attachments: BIGTOP-1373-extrafile.patch, 
> BIGTOP-1373-noextrafile.patch, BIGTOP-1373.patch
>
>
> This was brought up here (https://issues.apache.org/jira/browse/BIGTOP-1363) 
> as a much wanted feature for our build system so we can build against 
> branches. I have two approaches to doing this that I'll be posting up Patch 
> files for and seeing which approach everyone likes better. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to