[
https://issues.apache.org/jira/browse/BIGTOP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186241#comment-14186241
]
jay vyas edited comment on BIGTOP-1384 at 10/28/14 2:42 AM:
------------------------------------------------------------
[~dcapwell] thanks for the patch.
To get the *gradle wrapper* to work w/ smoke tests, two further things to be
done. we willl need to:
1) chmod {{gradlew}} to executable
2) in the smoke-tests, change {{./gradlew}} to {{/bigtop-home/gradlew}}
FYI, i remember you mentioning that you needed root password. heres the *easy
workaround*: you can just use "vagrant" as root password to become root. then
run tests as root.
After making chanes (1) and (2) above, im pretty sure {{vagrant up}} will work
perfectly.
Can you resubmit with those changes and (3) either use {{git format-patch}} to
make a commit with your author attribution or tell me the author user name to
use .
Thanks again ... looks pretty close . Im running a final test to confirm if
any other mods are needed.
.... UPDATE .... confirmed that, with the above two modifications, the
*smoke-tests.sh* script runs perfectly fine with your gradlew replacement. !
So feel free to make those 2 changes, and resubmit - and ill commit tomorrow.
was (Author: jayunit100):
[~dcapwell] thanks for the patch.
To get the *gradle wrapper* to work w/ smoke tests, two further things to be
done. we willl need to:
1) chmod {{gradlew}} to executable
2) in the smoke-tests, change {{./gradlew}} to {{/bigtop-home/gradlew}}
FYI, i remember you mentioning that you needed root password. heres the *easy
workaround*: you can just use "vagrant" as root password to become root. then
run tests as root.
After making chanes (1) and (2) above, im pretty sure {{vagrant up}} will work
perfectly.
Can you resubmit with those changes and (3) either use {{git format-patch}} to
make a commit with your author attribution or tell me the author user name to
use .
Thanks again ... looks pretty close . Im running a final test to confirm if
any other mods are needed.
> Implement Gradle Wrapper for smoke tests and cleanup.
> -----------------------------------------------------
>
> Key: BIGTOP-1384
> URL: https://issues.apache.org/jira/browse/BIGTOP-1384
> Project: Bigtop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: David Capwell
> Labels: build
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1384.patch
>
>
> By adding a the infamous *gradle wrapper script* (this is the idiom in gradle
> - to use the wrapper instead of a local gradle install) into our VCS, we
> gaurantee that the gradle tricks we implement will be running the exact same
> on all systems, no matter what.
> - Also, it opens the tests up to be runnable by anyone, even those who don't
> have gradle installed.
> - Finally, gradle wrapper will embolden us to be able to use more
> sophisticated gradle tricks newer features, b/c we will know that they run
> the same in all environments.
> So, this task consists of :
> 1) Adding gradle wrapper to the {{bigtop-smoke-tests}}
> 2) Implementing cleanup for the build.gradle files also, possibly allowing
> for version specific features (i.e. advanced dependency inheritance for
> subprojects etc)
> 3) Update README with new instructions for people running the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
