[
https://issues.apache.org/jira/browse/BIGTOP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188706#comment-14188706
]
jay vyas edited comment on BIGTOP-1384 at 10/29/14 6:11 PM:
------------------------------------------------------------
okay great it works by just running {{gradle-bootstrap}} ++ {{gradlew}} .
Id like to suggest we add *one line* to our custom {{gradlew}} which runs the
{{gradle-bootstrap}}.
- the reason is, that it will make the bigtop user experience awesome.
- it will save us time knowing we dont have to maintain "install gradle"
instructions in every damn readme .
Ive not used gradlew much, so i could be wrong. but id like feedback b4 we put
this in about wether we should just *go all out and make gradlew a fully
bootstarapping wrapper to gradle tasks in bigtop*
David and cos and i have gone back and forth on the idea. i think it will make
for the best user experience, so my vote is to *add that one extra line of
bootstrapping magic*, unless there is a serious technical reason not to do so.
was (Author: jayunit100):
okay great it works by just running {{gradle-bootstrap}} ++ {{gradlew}} .
Id like to suggest we add *one line* to our custom {{gradlew}} which runs the
{{gradle-bootstrap}}. the reason is, that it will make the bigtop user
experience awesome.
Ive not used gradlew much, so i could be wrong. but id like feedback b4 we put
this in about wether we should just *go all out and make gradlew a fully
bootstarapping wrapper to gradle tasks in bigtop*
David and cos and i have gone back and forth on the idea. i think it will make
for the best user experience, so my vote is to *add that one extra line of
bootstrapping magic*, unless there is a serious technical reason not to do so.
> Implement Gradle Wrapper for smoke tests and cleanup.
> -----------------------------------------------------
>
> Key: BIGTOP-1384
> URL: https://issues.apache.org/jira/browse/BIGTOP-1384
> Project: Bigtop
> Issue Type: Bug
> Components: build
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: David Capwell
> Labels: build
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1384.2.patch, BIGTOP-1384.patch
>
>
> By adding a the infamous *gradle wrapper script* (this is the idiom in gradle
> - to use the wrapper instead of a local gradle install) into our VCS, we
> gaurantee that the gradle tricks we implement will be running the exact same
> on all systems, no matter what.
> - Also, it opens the tests up to be runnable by anyone, even those who don't
> have gradle installed.
> - Finally, gradle wrapper will embolden us to be able to use more
> sophisticated gradle tricks newer features, b/c we will know that they run
> the same in all environments.
> So, this task consists of :
> 1) Adding gradle wrapper to the {{bigtop-smoke-tests}}
> 2) Implementing cleanup for the build.gradle files also, possibly allowing
> for version specific features (i.e. advanced dependency inheritance for
> subprojects etc)
> 3) Update README with new instructions for people running the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
