[
https://issues.apache.org/jira/browse/BIGTOP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186296#comment-14186296
]
David Capwell commented on BIGTOP-1384:
---------------------------------------
[~cos], thanks for the feedback.
"I don't like that exact version, e.g. gradle-2.1-bin.zip, is hardcoded. Is it
a requirement?"
This is gradle's configuration; this tells gradle where to pull the binaries
from. Normally auto-generated by running {code}gradle wrapper{code} (which is
how I created it).
"do we really need to check-in gradlew script? My impressions was that the damn
thing got generated on every run of the gradle build, isn't it?"
gradlew gets generated by calling {code}gradle wrapper{code}. The gradlew file
knows how to work with different versions of gradle and will install it for you
(assuming gradle-wrapper.jar is local). Only way I can think to remove gradlew
is to do what sbt has done, a global shell script that reads the configs and
does all the logic the wrapper does
(https://github.com/paulp/sbt-extras/blob/master/sbt).
"can we specify that the version needs to be 'greater than' instead of 'can
equal' (whatever it means)"
I can make the change but the largest value that worked for me was 0.8.0. I
assume that I need to populate the gradle artifact cache in order to get
something like 0.9.0-SNAPSHOT to work. Ill make this change tomorrow as well.
> Implement Gradle Wrapper for smoke tests and cleanup.
> -----------------------------------------------------
>
> Key: BIGTOP-1384
> URL: https://issues.apache.org/jira/browse/BIGTOP-1384
> Project: Bigtop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: David Capwell
> Labels: build
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1384.patch
>
>
> By adding a the infamous *gradle wrapper script* (this is the idiom in gradle
> - to use the wrapper instead of a local gradle install) into our VCS, we
> gaurantee that the gradle tricks we implement will be running the exact same
> on all systems, no matter what.
> - Also, it opens the tests up to be runnable by anyone, even those who don't
> have gradle installed.
> - Finally, gradle wrapper will embolden us to be able to use more
> sophisticated gradle tricks newer features, b/c we will know that they run
> the same in all environments.
> So, this task consists of :
> 1) Adding gradle wrapper to the {{bigtop-smoke-tests}}
> 2) Implementing cleanup for the build.gradle files also, possibly allowing
> for version specific features (i.e. advanced dependency inheritance for
> subprojects etc)
> 3) Update README with new instructions for people running the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
