[ 
https://issues.apache.org/jira/browse/BIGTOP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187184#comment-14187184
 ] 

Konstantin Boudnik commented on BIGTOP-1384:
--------------------------------------------

Agree on checking-in the source code. As for the hard-coded version: I am 
uneasy about it because this is sort of things that tends to be forgotten later 
and come back to bite you in the back when an incompatibility is introduced or 
something. I might be overly cautious here though.

> Implement Gradle Wrapper for smoke tests and cleanup.
> -----------------------------------------------------
>
>                 Key: BIGTOP-1384
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1384
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.8.0
>            Reporter: jay vyas
>            Assignee: David Capwell
>              Labels: build
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1384.patch
>
>
> By adding a the infamous *gradle wrapper script* (this is the idiom in gradle 
> - to use the wrapper instead of a local gradle install) into our VCS, we 
> gaurantee that the gradle tricks we implement will be running the exact same 
> on all systems, no matter what.
> - Also, it opens the tests up to be runnable by anyone, even those who don't 
> have gradle installed.
> - Finally, gradle wrapper will embolden us to be able to use more 
> sophisticated gradle tricks newer features, b/c we will know that they run 
> the same in all environments.
> So, this task consists of :
> 1) Adding gradle wrapper to the {{bigtop-smoke-tests}}
> 2) Implementing cleanup for the build.gradle files also, possibly allowing 
> for version specific features (i.e. advanced dependency inheritance for 
> subprojects etc)
> 3) Update README with new instructions for people running the tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to