[ 
https://issues.apache.org/jira/browse/BIGTOP-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189420#comment-14189420
 ] 

jay vyas commented on BIGTOP-1490:
----------------------------------

Tested this, 

- patch looks pretty clean, a few trailing whitespace but we can fix that when 
we apply {{--fix-whitespace}} 
- looks like it builds okay  using {{gradle gridgain-hadoop-rpm}}, 
- also confirmed that the rpm package seems to build properly 

is this just the hadoop part of gridgain ? Or the pure compute framework as 
well ( i thought gridgain had an alternative to mapreduce as well).

This is quite a sophisticated and large patch.  would love to see it 
accompanied with a mailing list announcement or wiki page update.

{noformat}
Requires: /bin/bash
Processing files: gridgain-hadoop-doc-6.5.2-1.fc20.noarch
Provides: gridgain-hadoop-doc = 6.5.2-1.fc20
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files 
/home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm/BUILDROOT/gridgain-hadoop-6.5.2-1.fc20.x86_64
Wrote: 
/home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm/RPMS/noarch/gridgain-hadoop-6.5.2-1.fc20.noarch.rpm
Wrote: 
/home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm/RPMS/noarch/gridgain-hadoop-service-6.5.2-1.fc20.noarch.rpm
Wrote: 
/home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm/RPMS/noarch/gridgain-hadoop-doc-6.5.2-1.fc20.noarch.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.Jas5xj
+ umask 022
+ cd /home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm//BUILD
+ cd gridgain-release-6.5.2
+ /usr/bin/rm -rf 
/home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm/BUILDROOT/gridgain-hadoop-6.5.2-1.fc20.x86_64
+ exit 0
Executing(--clean): /bin/sh -e /var/tmp/rpm-tmp.e30TaV
+ umask 022
+ cd /home/apache/Development/bigtop-jayunit100/build/gridgain-hadoop/rpm//BUILD
+ rm -rf gridgain-release-6.5.2
+ exit 0

BUILD SUCCESSFUL

Total time: 6 mins 40.441 secs
{noformat}

So,,, +1 from me !   The patch is functional and creates a rpm package.

Can one other bigtop commiter to sign off on it at a high level before we 
commit ?


> Adding GridGain to BigTop
> -------------------------
>
>                 Key: BIGTOP-1490
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1490
>             Project: Bigtop
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.8.0
>            Reporter: Dmitriy Setrakyan
>            Assignee: Ilya Tikhonov
>              Labels: gridgain
>             Fix For: 0.9.0
>
>         Attachments: 0001-BIGTOP-1490.-Adding-GridGain-to-BigTop.patch, 
> 0001-BIGTOP-1490.-Adding-GridGain-to-BigTop.patch, latest-201410111925.patch
>
>
> Please accept the patch of adding GridGain to the BigTop product. Addition of 
> GridGain was agreed upon in this thread:
> http://mail-archives.apache.org/mod_mbox/bigtop-dev/201403.mbox/%3CCA+0=VoXBik-=go=vmvb3pwbdv08dgbpem_ud7ndirr4hgux...@mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to