[
https://issues.apache.org/jira/browse/BIGTOP-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192069#comment-14192069
]
Konstantin Boudnik commented on BIGTOP-1490:
--------------------------------------------
Thanks [~pelya]! A couple of small comments on the test:
- you import Log facility yet keep using println for the output. Could you
please make the use of Log instead?
- I'd suggest to change input and output patch to something unique like
gh-input and gh-output. Also, do not use absolute path {{/}} because it is only
writable by user {{hdfs}} and you aren't guarantee to run the tests under the
account.
- I'd suggest to move clean up phase to {{@Before}} method instead of calling
it from the test itself.
- I see two {{log4j.properties}} files in {{conf/}} and in the test directory.
Do you think it's feasible to merge them together?
- do you think it is possible to keep the configuration files under {{conf/}}?
Or they are better be in the test directory?
Last comment: the patch applies with a few whitespace warnings. Could you take
a stab at fixing them? Thanks!
> Adding GridGain to BigTop
> -------------------------
>
> Key: BIGTOP-1490
> URL: https://issues.apache.org/jira/browse/BIGTOP-1490
> Project: Bigtop
> Issue Type: Bug
> Components: general
> Affects Versions: 0.8.0
> Reporter: Dmitriy Setrakyan
> Assignee: Ilya Tikhonov
> Labels: gridgain
> Fix For: 0.9.0
>
> Attachments: 0001-BIGTOP-1490.-Adding-GridGain-to-BigTop.patch,
> 0001-BIGTOP-1490.-Adding-GridGain-to-BigTop.patch,
> 0001-BIGTOP-1490.-Adding-GridGain-to-BigTop.patch, latest-201410111925.patch
>
>
> Please accept the patch of adding GridGain to the BigTop product. Addition of
> GridGain was agreed upon in this thread:
> http://mail-archives.apache.org/mod_mbox/bigtop-dev/201403.mbox/%3CCA+0=VoXBik-=go=vmvb3pwbdv08dgbpem_ud7ndirr4hgux...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
