[
https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208793#comment-14208793
]
Konstantin Boudnik commented on BIGTOP-1524:
--------------------------------------------
- let's document the use of the sys. props
{{System.getProperty("useFailureProperties"...)}} in the JavaDoc or readme or
else, so the next user doesn't need to fish in the code
- This looks like a formatting change that doesn't belong here
{code}
- switch (OS.linux_flavor) {
+ switch (OS.linux_flavor) {
{code}
- I am not sure it's a good idea to expose the innards of the test framework as
a test
{code}
+ "TestHadoopExamples.groovy",
+ "FailureVars.groovy"
{code}
- Is this intentional?
{code}
- //print("Exclude? ${filename} ... ")
+ print("Exclude? ${filename} ... ")
....
- //println("Keep = ${keep_this_test} "+filename);
+ println("Keep = ${keep_this_test} "+filename);
+
{code}
- if you aren't using this line, why not to remove it?
{code}
- testCompile group: 'org.apache.bigtop.itest', name: 'itest-common', version:
itestVersion, transitive: 'true'
+ // testCompile group: 'org.apache.bigtop.itest', name: 'itest-common',
version: itestVersion, transitive: 'true'
{code}
- seems like a formatting change, irrelevant to the fix
{code}
- srcDirs = [
- 'conf/',
- ]
- }
+ srcDirs = ['conf/']
+ }
+
{code}
- the only line that is really relevant to this JIRA is this
{code}
+import org.apache.bigtop.itest.failures.FailureVars
{code}
and it's an interesting one because without this import TestHadoopExamples
compiles just fine. Perhaps it is specific to the smoke tests organization?
> FailureExecutor breaks smoke tests : Smoke tests should run from source
> ------------------------------------------------------------------------
>
> Key: BIGTOP-1524
> URL: https://issues.apache.org/jira/browse/BIGTOP-1524
> Project: Bigtop
> Issue Type: Bug
> Components: tests
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: jay vyas
> Priority: Blocker
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the
> existing mapreduce smoke tests.
> Maybe i can add ITest as a compiled, rather than jar file, dependency for
> {{smoke-tests}} . let me look into it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
