[
https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209248#comment-14209248
]
Konstantin Boudnik commented on BIGTOP-1524:
--------------------------------------------
Two more things:
- please document the use of this variable
{code}
+ private Boolean useProperties =
Boolean.parseBoolean(System.getProperty("useFailureProperties", "false"));
{code}
- looks like unmatched versions of groovy here, no?
{code}
testCompile module('org.codehaus.groovy:groovy:1.8.0')
...
+ compile "org.codehaus.groovy:groovy-all:2.1.5"
{code}
- these lines are misaligned
{code}
+ srcDirs = [
+
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/",
+
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/"
+ ]
{code}
- unwarranted indentation change
{code}
- 'conf/',
+ 'conf/'
{code}
- indentation is wrong here as well
{code}
srcDirs = [
-
"$System.env.BIGTOP_HOME"+"/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/mapreduce"]
+
"$System.env.BIGTOP_HOME"+"/bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/mapreduce",
+
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/",
+
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/"
+ ]
{code}
Thanks!
> FailureExecutor breaks smoke tests : Smoke tests should run from source
> ------------------------------------------------------------------------
>
> Key: BIGTOP-1524
> URL: https://issues.apache.org/jira/browse/BIGTOP-1524
> Project: Bigtop
> Issue Type: Bug
> Components: tests
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: jay vyas
> Priority: Blocker
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the
> existing mapreduce smoke tests.
> Maybe i can add ITest as a compiled, rather than jar file, dependency for
> {{smoke-tests}} . let me look into it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
