[
https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229869#comment-14229869
]
jay vyas edited comment on BIGTOP-1524 at 12/1/14 3:18 PM:
-----------------------------------------------------------
Hi [~cos] . I think, this hunk looks good to me .... What it is doing is
updating the vagrant tester to make sure it runs *mapreduce* tests.
TL;DR *this hunk you are referring to fixes a bug and includes an update to the
testing framework which reproduces the bug so that we dont regress*.
(details)
The reason that is important (and most relevant to BIGTOP-1524) is because
*FailureVars* broke the mapreduce tests, specifically.
So this patch includes a update to the automated tests, that they run
*mapreduce* as well as *pig* at a minimum when we test releases using vagrant.
Makes sense now ? Or let me know if Im missing something.
{noformat}
diff --git a/bigtop-deploy/vm/smoke-tests.sh b/bigtop-deploy/vm/smoke-tests.sh
index cfb4050..abc0c09 100755
--- a/bigtop-deploy/vm/smoke-tests.sh
+++ b/bigtop-deploy/vm/smoke-tests.sh
@@ -17,4 +17,4 @@ su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777
/user/vagrant'
su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777 /user/root'
yum install -y pig hive flume mahout
-cd /bigtop-home/bigtop-tests/smoke-tests && ./gradlew compileGroovy test
-Dsmoke.tests=pig --info
+cd /bigtop-home/bigtop-tests/smoke-tests && ./gradlew clean compileGroovy test
-Dsmoke.tests=mapreduce,pig --info
{noformat}
was (Author: jayunit100):
Hi [~cos] . I think, this hunk looks good to me .... What it is doing is
updating the vagrant tester to make sure it runs *mapreduce* tests.
The reason that is important (and most relevant to BIGTOP-1524) is because
*FailureVars* broke the mapreduce tests, specifically.
So this patch includes a update to the automated tests, that they run
*mapreduce* as well as *pig* at a minimum when we test releases using vagrant.
Makes sense now ? Or let me know if Im missing something.
{noformat}
diff --git a/bigtop-deploy/vm/smoke-tests.sh b/bigtop-deploy/vm/smoke-tests.sh
index cfb4050..abc0c09 100755
--- a/bigtop-deploy/vm/smoke-tests.sh
+++ b/bigtop-deploy/vm/smoke-tests.sh
@@ -17,4 +17,4 @@ su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777
/user/vagrant'
su -s /bin/bash $HCFS_USER -c 'hadoop fs -chmod 777 /user/root'
yum install -y pig hive flume mahout
-cd /bigtop-home/bigtop-tests/smoke-tests && ./gradlew compileGroovy test
-Dsmoke.tests=pig --info
+cd /bigtop-home/bigtop-tests/smoke-tests && ./gradlew clean compileGroovy test
-Dsmoke.tests=mapreduce,pig --info
{noformat}
> FailureExecutor breaks smoke tests : Smoke tests should run from source
> ------------------------------------------------------------------------
>
> Key: BIGTOP-1524
> URL: https://issues.apache.org/jira/browse/BIGTOP-1524
> Project: Bigtop
> Issue Type: Bug
> Components: tests
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: jay vyas
> Priority: Blocker
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1524.patch, BIGTOP-1524.patch, BIGTOP-1524.patch,
> BIGTOP-1524.patch, BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the
> existing mapreduce smoke tests.
> Maybe i can add ITest as a compiled, rather than jar file, dependency for
> {{smoke-tests}} . let me look into it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
