[
https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230329#comment-14230329
]
jay vyas edited comment on BIGTOP-1524 at 12/1/14 7:54 PM:
-----------------------------------------------------------
bq. improving the vagrant tests isn't relevant...
okay, so im a little confused - b/c this patch is specifically about the
vagrant tests. let me ask another way: for future, do you think that the
vagrant updates should happen *before* submitting this patch or *afterwards*
? For me I think its a *simultaneous* thing ~ you would ideally want to have
the tests commited *along side the fix*, commiting after doesnt help you verify
that the fix is actually doing anything. Let me know, it could help me in the
future w/ later JIRAs... (or possibly i should have just been more clear in the
comment thread about what the vagrant modification was for)
was (Author: jayunit100):
bq. improving the vagrant tests isn't relevant...
okay, so im a little confused - b/c this patch is specifically about the
vagrant tests. let me ask another way: for future, do you think that the
vagrant updates should happen *before* submitting this patch or *afterwards*
? *For me* I think its a simultaneous thing ~ you would ideally want to have
the tests commited *along side the fix*, commiting after doesnt help you verify
that the fix is actually doing anything. Let me know, it could help me in the
future w/ later JIRAs.
> FailureExecutor breaks smoke tests : Smoke tests should run from source
> ------------------------------------------------------------------------
>
> Key: BIGTOP-1524
> URL: https://issues.apache.org/jira/browse/BIGTOP-1524
> Project: Bigtop
> Issue Type: Bug
> Components: tests
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: jay vyas
> Priority: Blocker
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1524.patch, BIGTOP-1524.patch, BIGTOP-1524.patch,
> BIGTOP-1524.patch, BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the
> existing mapreduce smoke tests.
> Maybe i can add ITest as a compiled, rather than jar file, dependency for
> {{smoke-tests}} . let me look into it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
